Merge PR_26171_012-message-tool-postgres-table-layout-cleanup

Author: ToolboxAid

docs_build/dev/PROJECT_INSTRUCTIONS.md

@@ -358,6 +358,20 @@ Prohibited product-data ownership:
 
 Toolbox and Admin tool metadata must use a shared DB-backed tool metadata source for `toolKey`, `toolName`, `group`, `path`, `order`, and `status`. Browser pages may render metadata returned by the API/service contract, but they must not own a separate runtime copy of that metadata.
 
+## POSTGRES DATABASE DIRECTION
+
+SQLite is deprecated for new database work.
+
+Rules:
+- New database work must target Postgres.
+- New persistence must flow through Local API / Postgres direction only.
+- Do not add new SQLite services.
+- Do not add new SQLite DDL.
+- Do not add new SQLite seed data.
+- Do not add new SQLite runtime persistence.
+- Legacy SQLite references may remain only as documented technical debt when they already exist.
+- Browser code must not own product data or generate authoritative persistence keys.
+
 ## DEV RUNTIME BOUNDARY
 
 All mock/dev-only runtime implementation must live under `src/dev-runtime/`.

docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup-manual-validation.md

@@ -0,0 +1,11 @@
+# Manual Validation Notes
+
+- Opened `/tools/messages/index.html` through the repo Playwright server.
+- Verified browser-rendered document title: `Message Studio - GameFoundryStudio`.
+- Verified browser-rendered H1: `Message Studio`.
+- Verified visible category/category controls are absent from the Message Studio page.
+- Verified Message Rows appears before row detail editing.
+- Verified visible row actions use `Add Message Row`, `Update Row`, and `Disable Row`.
+- Verified Emotion Profiles and TTS Profiles appear in the center work surface.
+- Verified Speech Preview remains display-only in the inspector.
+- Verified no provider calls, audio generation, playback generation, delete behavior, or new SQLite persistence was introduced.

docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup-validation.txt

@@ -0,0 +1,33 @@
+Validation report for PR_26171_012-message-tool-postgres-table-layout-cleanup
+
+Branch and git validation:
+- git branch --show-current: main
+- git checkout main: PASS
+- git -c http.sslBackend=schannel pull origin main: PASS, already up to date
+- git status before branch: PASS, clean
+- git checkout -b pr/26171-012-message-tool-postgres-table-layout-cleanup: PASS
+
+Static validation:
+- node --check toolbox/messages/messages.js: PASS
+- node --check src/shared/toolbox/tool-metadata-inventory.js: PASS
+- node --check src/dev-runtime/server/local-api-router.mjs: PASS
+- node --check tests/playwright/tools/MessagesTool.spec.mjs: PASS
+- node --check tests/playwright/tools/RootToolsFutureState.spec.mjs: PASS
+- git diff --check for touched files: PASS with CRLF warnings only
+
+Targeted UI/static validation:
+- Category/category visible UI removed from toolbox/messages/index.html: PASS
+- Save Message / New Message / Message Editor visible copy removed from toolbox/messages/index.html: PASS
+- Inline style/script/event handler check for toolbox/messages/index.html: PASS
+- Rendered tool title/H1 after registry override: PASS, Message Studio
+
+Playwright:
+- npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list: PASS, 2 passed
+- npm run test:workspace-v2: WARN, 3 passed / 2 failed
+  - Remaining failures are existing header ordering expectations:
+    - root tools surface links current tool pages without old_* routes
+    - common header renders primary navigation order across active pages
+  - Both failures compare expected alphabetical Toolbox menu order `Game Hub` before `Game Journey` against current UI order `Game Journey` before `Game Hub`.
+
+Samples:
+- Full samples validation: SKIP, no samples changed.

docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup.md

@@ -0,0 +1,59 @@
+# PR_26171_012-message-tool-postgres-table-layout-cleanup
+
+## Branch Validation
+
+- Current branch before implementation: `main`
+- Required PR branch: `pr/26171-012-message-tool-postgres-table-layout-cleanup`
+- Branch source: pulled latest `origin/main` before branch creation
+- Clean repo before branch creation: PASS
+
+## Summary
+
+Message Studio now reflects the approved Postgres direction and creator-facing row workflow. The tool no longer exposes category management or category selection in the UI, Emotion Profiles and TTS Profiles are in the center work surface, and the message editor is organized around a Message Rows table with Add/Update/Disable row language.
+
+## Requirement Checklist
+
+| Requirement | Result | Evidence |
+| --- | --- | --- |
+| Update repo guidance to state SQLite is deprecated. | PASS | Added `POSTGRES DATABASE DIRECTION` to `docs_build/dev/PROJECT_INSTRUCTIONS.md`. |
+| New database work must target Postgres / Local API direction. | PASS | Guidance now requires new persistence through Local API / Postgres direction only. |
+| Do not add new SQLite services, DDL, seed, or runtime persistence. | PASS | No SQLite service, DDL, seed, or persistence file was added. Existing legacy SQLite service remains unchanged as technical debt. |
+| Remove Category/category UI from the left column. | PASS | `toolbox/messages/index.html` no longer contains visible category controls or category tables. |
+| Do not introduce category replacement. | PASS | No new classification form was introduced; left column documents Tags as the future direction only. |
+| Move Emotion Profiles into center column. | PASS | Emotion Profiles form/table now render in the center work surface. |
+| Move TTS Profiles into center column. | PASS | TTS Profiles form/table now render in the center work surface. |
+| Keep Speech Preview display-only. | PASS | Speech Preview remains in the inspector and no provider/audio generation behavior was added. |
+| Change Message Editor to table-driven workflow. | PASS | Message Rows table now appears before row detail editing. |
+| Add new row/action at bottom of table. | PASS | Message Rows table includes `Add Message Row` below the table. |
+| Avoid Save Message / New Message language. | PASS | Visible tool copy now uses `Add Message Row`, `Update Row`, and `Disable Row`. |
+| Preferred visible label is Message Studio. | PASS | Page title/H1 and source-controlled Toolbox metadata now use `Message Studio`. |
+| Do not rename routes/folders. | PASS | Existing `messages` route/folder/id remain unchanged. |
+
+## Root Cause / Notes
+
+The tool was still presenting the earlier Messages foundation UI: category management in the left rail, Emotion/TTS profile management outside the primary work surface, and form-first `Save Message` / `New Message` actions. The server-backed toolbox registry also retained the old `Messages` label because `messages` was not included in the source-controlled metadata sync allowlist.
+
+This PR keeps the current legacy category key only as an internal compatibility value required by the existing API contract. The category UI is removed from the creator surface and the Postgres migration direction is documented.
+
+## Impacted Lane
+
+- Tool/UI lane: Message Studio Theme V2 surface
+- Server metadata lane: Toolbox registry source-controlled metadata sync
+- Documentation/governance lane: database direction guidance
+
+## Skipped Lanes
+
+- Samples: skipped, no sample runtime or sample JSON changed.
+- Provider/audio generation: skipped, explicitly out of scope.
+- Full samples smoke: skipped, out of scope.
+
+## Playwright Result
+
+- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list`
+- WARN: `npm run test:workspace-v2` still fails on existing header ordering expectations where the UI renders `Game Journey` before `Game Hub`. The PR-caused Toolbox count expectation was updated from `13/42` to `14/43`.
+
+## Manual Validation Notes
+
+- Confirmed rendered `/tools/messages/index.html` title and H1 resolve to `Message Studio` after the server registry override.
+- Confirmed visible category controls are absent from `toolbox/messages/index.html`.
+- Confirmed no inline style blocks, inline scripts, or inline event handlers were added.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,11 +1,12 @@
-docs_build/dev/commit_comment.txt
-docs_build/dev/reports/PR_26171_010-message-speech-preview-manual-validation.md
-docs_build/dev/reports/PR_26171_010-message-speech-preview-validation.txt
-docs_build/dev/reports/PR_26171_010-message-speech-preview.md
+docs_build/dev/PROJECT_INSTRUCTIONS.md
+docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup-manual-validation.md
+docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup-validation.txt
+docs_build/dev/reports/PR_26171_012-message-tool-postgres-table-layout-cleanup.md
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
-docs_build/dev/reports/coverage_changed_js_guardrail.txt
-docs_build/dev/reports/playwright_v8_coverage_report.txt
+src/dev-runtime/server/local-api-router.mjs
+src/shared/toolbox/tool-metadata-inventory.js
 tests/playwright/tools/MessagesTool.spec.mjs
+tests/playwright/tools/RootToolsFutureState.spec.mjs
 toolbox/messages/index.html
 toolbox/messages/messages.js