Rebuild Controls input mapping from UAT and legacy UX reference - PR_26161_016-controls-input-mapping-rebuild

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,18 +1,30 @@
 # git status --short
 M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M tests/playwright/tools/ObjectsTool.spec.mjs
- M toolbox/objects/index.html
- M toolbox/objects/objects.js
-?? docs_build/dev/reports/objects-remove-type-choices-report.md
+ M src/dev-runtime/admin/header-nav.local.html
+ M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
+ M src/dev-runtime/persistence/mock-db-store.js
+ M src/dev-runtime/server/mock-api-router.mjs
+ M toolbox/controls/index.html
+?? docs_build/dev/reports/controls-input-mapping-rebuild-report.md
+?? src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
+?? tests/playwright/tools/InputMappingV2Tool.spec.mjs
+?? toolbox/input-mapping-v2/
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/objects-remove-type-choices-report.md
+docs_build/dev/reports/controls-input-mapping-rebuild-report.md
+src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
+tests/playwright/tools/InputMappingV2Tool.spec.mjs
+toolbox/input-mapping-v2/index.html
+toolbox/input-mapping-v2/input-mapping-api-client.js
+toolbox/input-mapping-v2/input-mapping-v2.js
 
 # git diff --stat
-docs_build/dev/reports/coverage_changed_js_guardrail.txt |  2 +-
- docs_build/dev/reports/playwright_v8_coverage_report.txt |  8 ++++----
- tests/playwright/tools/ObjectsTool.spec.mjs              | 14 +++++++++++---
- toolbox/objects/index.html                               |  7 -------
- toolbox/objects/objects.js                               |  2 +-
- 5 files changed, 17 insertions(+), 16 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  | 11 ++-
+ .../dev/reports/playwright_v8_coverage_report.txt  | 35 ++++----
+ src/dev-runtime/admin/header-nav.local.html        |  2 +-
+ .../guest-seeds/tool-metadata-inventory.js         | 13 +--
+ src/dev-runtime/persistence/mock-db-store.js       |  5 ++
+ src/dev-runtime/server/mock-api-router.mjs         | 20 ++++-
+ toolbox/controls/index.html                        | 94 +++++++++++++++++++---
+ 7 files changed, 148 insertions(+), 32 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,98 @@
+# PR_26161_016 Controls Input Mapping Rebuild Report
+
+## Branch Validation
+
+PASS
+
+- Current branch: `main`
+- Expected branch: `main`
+- Worktree was clean before PR_26161_016 edits.
+
+## Scope
+
+- Impacted lane: Controls/Input Mapping tool UI/runtime, shared mock DB adapter table registration, local mock API repository routing, Controls metadata launch route, and targeted Playwright coverage.
+- Playwright impacted: Yes.
+- Runtime engine behavior changed: No.
+- Samples validation: Skipped as requested. No sample JSON alignment, auth behavior, production DB behavior, or engine runtime behavior changed.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Verified current git branch was `main` before edits.
+- PASS: Reviewed `docs_build/tools/input-mapping-v2/uat.md` before implementation.
+- PASS: Used `archive/v1-v2/tools/old_input-mapping-v2/` as UX/reference only; no legacy CSS, shell, inline patterns, or deprecated structure were copied.
+- PASS: Rebuilt Controls/Input Mapping with current Theme V2 layout and external JavaScript only.
+- PASS: Added `toolbox/input-mapping-v2/index.html` as the UAT launch route.
+- PASS: Replaced the old `toolbox/controls/index.html` wireframe with the rebuilt working surface for compatibility.
+- PASS: Updated Controls metadata/nav launch route to `toolbox/input-mapping-v2/index.html`.
+- PASS: Promoted Controls metadata status to `beta` for the rebuilt DB-backed tool.
+- PASS: Preserved useful old workflow concepts: default actions, keyboard capture, mouse capture, gamepad capture WARN, mapping list, Mapping JSON/status output, and device/source diagnostics.
+- PASS: Implemented table-first mapping input with `Object | Action | Input Device | Input | State | Actions`.
+- PASS: Uses Objects DB records as selectable Object values when available.
+- PASS: Persists mappings through the shared DB/mock adapter via `input_mapping_records`, not page-local-only storage.
+- PASS: Default actions are alphabetically sorted and include movement, confirm/cancel, fire, thrust, rotation, Pause, Select, and Start.
+- PASS: Workspace launch mode shows `Return to Workspace`.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only; no inline CSS, inline JS, script/style blocks, or inline event handlers.
+
+## Testing Performed
+
+- PASS: `node --check toolbox/input-mapping-v2/input-mapping-v2.js`
+- PASS: `node --check toolbox/input-mapping-v2/input-mapping-api-client.js`
+- PASS: `node --check src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js`
+- PASS: `node --check src/dev-runtime/server/mock-api-router.mjs`
+- PASS: `node --check src/dev-runtime/persistence/mock-db-store.js`
+- PASS: `node --check src/dev-runtime/guest-seeds/tool-metadata-inventory.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: `rg --pcre2 -n '<script(?![^>]*\bsrc=)|<style\b|\son[a-z]+\s*=' toolbox/input-mapping-v2/index.html toolbox/controls/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `rg -n 'Static wireframe only|Not implemented yet|no database|no runtime behavior|legacy CSS|deprecated structure|session-only|MVP' toolbox/input-mapping-v2/index.html toolbox/controls/index.html toolbox/input-mapping-v2/input-mapping-v2.js`
+  - Expected no matches; command exited with no matches.
+- PASS: `git diff --check`
+  - Result: PASS. Git reported line-ending normalization warnings only.
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --workers=1 --reporter=line`
+  - Result: 3 passed.
+
+## Playwright Behavior Covered
+
+- PASS: UAT launch route `/toolbox/input-mapping-v2/index.html` renders the required panels: Actions, Capture, Mappings, Mapping JSON, Devices, and Status.
+- PASS: Workspace launch query shows `Return to Workspace`.
+- PASS: Mapping table columns are `Object`, `Action`, `Input Device`, `Input`, `State`, and `Actions`.
+- PASS: Default actions are sorted alphabetically and include movement, confirm/cancel, fire, thrust, rotation, Pause, Select, and Start.
+- PASS: Device diagnostics list `InputService + KeyboardState`, `InputService + MouseState`, `InputService + GamepadState + GamepadInputAdapter`, and `GamepadInputAdapter`.
+- PASS: Device refresh updates the status log.
+- PASS: Gamepad capture shows an actionable `WARN` when no live browser gamepad value is available.
+- PASS: Keyboard capture maps `KeyA` to the selected `Move Left` action.
+- PASS: Captured token `Keyboard KeyA` deletes the persisted mapping when clicked.
+- PASS: Objects DB records are available as selectable Object values.
+- PASS: Mapping records persist through the shared DB/mock adapter after reload.
+- PASS: Compatibility route `/toolbox/controls/index.html` uses the rebuilt Input Mapping surface and no longer shows wireframe-only copy.
+- PASS: Controls registry route resolves to `toolbox/input-mapping-v2/index.html` with status `beta`.
+
+## Playwright V8 Coverage
+
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Current PR browser runtime JavaScript coverage:
+  - `(81%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 700/700; executed functions 64/79`
+  - `(100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2`
+- Advisory WARN entries remain for server/dev-runtime files because Playwright browser V8 coverage does not collect Node-side mock API modules.
+- The report may also list previous `HEAD` changed JS such as Objects files; those are advisory from the coverage helper's HEAD comparison and are not PR_26161_016 worktree changes.
+
+## Manual Validation Steps
+
+1. Open `/toolbox/input-mapping-v2/index.html?workspace=demo-project`.
+2. Confirm `Return to Workspace` is visible.
+3. Confirm Actions, Capture, Mappings, Mapping JSON, Devices, and Status panels appear.
+4. Confirm the default action dropdown is alphabetically sorted and includes Pause, Select, and Start.
+5. Select `Move Left`, click `Capture Keyboard`, press `A`, and confirm `Keyboard KeyA` appears in the mapping table and JSON.
+6. Click the `Keyboard KeyA` token and confirm the mapping is deleted.
+7. Click `Capture Gamepad` with no live gamepad value and confirm the actionable WARN.
+8. Create or seed an Object record, reload Input Mapping, and confirm the Object dropdown includes it.
+9. Reload after saving a mapping and confirm the mapping persists from `input_mapping_records`.
+
+## Skipped Lanes
+
+- Full samples validation: SKIP, explicitly requested and no samples changed.
+- Full workspace/project suite: SKIP, broad Project Workspace behavior was not changed; targeted Playwright validates the UAT launch return action and Controls registry route.
+- Engine runtime tests: SKIP, no `src/engine/input` behavior changed.
+- Auth and production DB validation: SKIP, no auth or production DB behavior changed; shared mock DB adapter wiring was covered by targeted Playwright and syntax checks.

docs_build/dev/reports/controls-input-mapping-rebuild-report.md

@@ -7,7 +7,16 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) toolbox/objects/objects.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(81%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 700/700; executed functions 64/79
+(100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 
 Guardrail warnings:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) toolbox/objects/objects.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,35 +12,42 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(85%) Toolbox Index - exercised 6 runtime JS files
+(80%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) toolbox/objects/objects.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(81%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 700/700; executed functions 64/79
+(100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 
 Files with executed line/function counts where available:
-(33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
-(38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(67%) src/engine/object-model/objectModelRegistry.js - executed lines 139/139; executed functions 4/6
-(67%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 2/3
-(70%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 16/23
-(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
-(77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
-(86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
-(100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
+(75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
+(81%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 700/700; executed functions 64/79
+(100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
-(100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(0%) toolbox/objects/objects.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(93%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
+(0%) toolbox/objects/objects.js - changed JS file not collected as browser runtime coverage
+(81%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage
+(100%) toolbox/input-mapping-v2/input-mapping-api-client.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -84,7 +84,7 @@
           <div class="nav-item nav-popout-item" data-toolbox-menu-group>
             <a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Test &#9656;</a>
             <div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="Test tools">
-              <a data-nav-link data-toolbox-menu-item data-route="tool-controls" href="toolbox/controls/index.html">Controls</a>
+              <a data-nav-link data-toolbox-menu-item data-route="tool-controls" href="toolbox/input-mapping-v2/index.html">Controls</a>
               <a data-nav-link data-toolbox-menu-item data-route="debug" href="toolbox/debug/index.html">Debug</a>
               <a data-nav-link data-toolbox-menu-item data-route="events" href="toolbox/events/index.html">Events</a>
               <a data-nav-link data-toolbox-menu-item data-route="game-testing" href="toolbox/game-testing/index.html">Game Testing</a>

src/dev-runtime/admin/header-nav.local.html

@@ -716,9 +716,9 @@ export const TOOL_REGISTRY = Object.freeze([
     "displayName": "Controls",
     "shortDescription": "Map keyboard, mouse, gamepad, and touch controls.",
     "shortLabel": "Controls",
-    "path": "controls",
-    "folderName": "controls",
-    "entryPoint": "controls/index.html",
+    "path": "input-mapping-v2",
+    "folderName": "input-mapping-v2",
+    "entryPoint": "input-mapping-v2/index.html",
     "badge": "/assets/theme-v2/images/badges/controls.png",
     "tool": "/assets/theme-v2/images/tools/controls.png",
     "description": "Map keyboard, mouse, gamepad, and touch controls.",
@@ -730,10 +730,11 @@ export const TOOL_REGISTRY = Object.freeze([
     "requiredForTestable": true,
     "requiredForPublish": true,
     "requires": [],
-    "status": "Wireframe",
+    "status": "beta",
     "progressChecklist": [
-      "Review readiness",
-      "Static planned text only"
+      "Map object actions",
+      "Capture keyboard, mouse, and gamepad inputs",
+      "Persist mappings through shared DB adapter"
     ],
     "deferred": false,
     "hidden": false,

src/dev-runtime/guest-seeds/tool-metadata-inventory.js

@@ -87,6 +87,10 @@ export const MOCK_DB_TOOL_GROUPS = Object.freeze({
     label: "Objects",
     tableNames: Object.freeze(["object_definition_records"]),
   }),
+  "input-mapping-v2": Object.freeze({
+    label: "Input Mapping",
+    tableNames: Object.freeze(["input_mapping_records"]),
+  }),
   "project-journey": Object.freeze({
     label: "Project Journey",
     tableNames: Object.freeze([
@@ -132,6 +136,7 @@ const MOCK_DB_TABLE_SCHEMAS = Object.freeze({
   game_configuration_records: Object.freeze(["key", "projectKey", "status", "summary", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   game_configuration_validation_items: Object.freeze(["key", "projectKey", "label", "status", "action", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   object_definition_records: Object.freeze(["key", "id", "projectId", "name", "type", "state", "modelType", "renderType", "renderAssetKey", "renderPreviewPath", "capabilities", "behavior", "interaction", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
+  input_mapping_records: Object.freeze(["key", "id", "projectId", "objectKey", "objectName", "action", "actionLabel", "inputDevice", "source", "binding", "label", "engine", "state", "recordOrder", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_note_types: Object.freeze(["key", "typeSlug", "name", "seeded", "userExtensible", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_notes: Object.freeze(["key", "slug", "projectKey", "ownerKey", "name", "typeKey", "createdAt", "updatedAt", "createdBy", "updatedBy"]),
   project_journey_templates: Object.freeze(["key", "templateSlug", "originalMeaning", "systemGuidance", "linkedToolContexts", "version", "isActive", "createdAt", "updatedAt", "createdBy", "updatedBy"]),