Restore Palette source swatches and add Pin All compact controls - PR_26156_171-palette-source-pinall-compact-buttons

ToolboxAid · ToolboxAid · commit fb3d804cb697 · 2026-06-05T19:03:38.000-04:00
diff --git a/assets/theme-v2/css/buttons.css b/assets/theme-v2/css/buttons.css
@@ -17,6 +17,14 @@
   border-color: var(--orange-border-strong)
 }
 
+.btn--compact {
+  margin: var(--space-0);
+  padding: var(--space-3) var(--space-8);
+  font-size: var(--font-size-xs);
+  font-weight: 600;
+  line-height: var(--line-height-sm)
+}
+
 .btn.cyan {
   background: var(--button-cyan-background)
 }
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -6,8 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
-(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
+(85%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 98/115
+(92%) toolbox/colors/colors.js - executed lines 694/694; executed functions 69/75
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings
diff --git a/docs_build/dev/reports/dependency_gating_report.md b/docs_build/dev/reports/dependency_gating_report.md
@@ -1,6 +1,6 @@
 # Dependency Gating Report
 
-Generated: 2026-06-05T22:47:48.644Z
+Generated: 2026-06-05T23:00:27.527Z
 Status: PASS
 
 ## Gate Order
diff --git a/docs_build/dev/reports/dependency_hydration_reuse_report.md b/docs_build/dev/reports/dependency_hydration_reuse_report.md
@@ -1,6 +1,6 @@
 # Dependency Hydration Reuse Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/execution_graph_reuse_report.md b/docs_build/dev/reports/execution_graph_reuse_report.md
@@ -1,6 +1,6 @@
 # Execution Graph Reuse Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/failure_fingerprint_report.md b/docs_build/dev/reports/failure_fingerprint_report.md
@@ -1,6 +1,6 @@
 # Failure Fingerprint Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/incremental_validation_report.md b/docs_build/dev/reports/incremental_validation_report.md
@@ -1,6 +1,6 @@
 # Incremental Validation Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Reuse Summary
diff --git a/docs_build/dev/reports/lane_compilation_report.md b/docs_build/dev/reports/lane_compilation_report.md
@@ -1,6 +1,6 @@
 # Lane Compilation Report
 
-Generated: 2026-06-05T22:47:48.644Z
+Generated: 2026-06-05T23:00:27.527Z
 Status: PASS
 
 ## Lane Graph
diff --git a/docs_build/dev/reports/lane_deduplication_report.md b/docs_build/dev/reports/lane_deduplication_report.md
@@ -1,6 +1,6 @@
 # Lane Deduplication Report
 
-Generated: 2026-06-05T22:47:48.644Z
+Generated: 2026-06-05T23:00:27.527Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/lane_input_validation_report.md b/docs_build/dev/reports/lane_input_validation_report.md
@@ -1,6 +1,6 @@
 # Lane Input Validation Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Input Files
diff --git a/docs_build/dev/reports/lane_runtime_optimization_report.md b/docs_build/dev/reports/lane_runtime_optimization_report.md
@@ -1,6 +1,6 @@
 # Lane Runtime Optimization Report
 
-Generated: 2026-06-05T22:47:48.644Z
+Generated: 2026-06-05T23:00:27.527Z
 Status: PASS
 
 ## Runtime Cost Summary
diff --git a/docs_build/dev/reports/lane_snapshot_report.md b/docs_build/dev/reports/lane_snapshot_report.md
@@ -1,6 +1,6 @@
 # Lane Snapshot Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 Snapshot directory: docs_build/dev/reports/lane_snapshots
 
diff --git a/docs_build/dev/reports/lane_warm_start_report.md b/docs_build/dev/reports/lane_warm_start_report.md
@@ -1,6 +1,6 @@
 # Lane Warm-Start Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.527Z
 Status: PASS
 Warm-start directory: docs_build/dev/reports/lane_warm_starts
 
diff --git a/docs_build/dev/reports/monolith_trigger_removal_report.md b/docs_build/dev/reports/monolith_trigger_removal_report.md
@@ -1,6 +1,6 @@
 # Monolith Trigger Removal Report
 
-Generated: 2026-06-05T22:47:48.647Z
+Generated: 2026-06-05T23:00:27.530Z
 Status: PASS
 
 ## Removed Broad Execution Triggers
diff --git a/docs_build/dev/reports/palette-source-pinall-compact-buttons-report.md b/docs_build/dev/reports/palette-source-pinall-compact-buttons-report.md
@@ -0,0 +1,55 @@
+# PR_26156_171 Palette Source Pin All Compact Buttons Report
+
+## Result
+PASS
+
+## Scope
+- Fixed Palette Tool source loading after removing `DEFAULT_SOURCE_PALETTES`.
+- Source Palette Browser now reads source swatches from `palette_source_swatches` DB/mock-DB table rows.
+- The normal mock-DB path renders visible source swatches.
+- The empty diagnostic appears only when `palette_source_swatches` is explicitly empty.
+- Added Source Palette Browser `Pin All`.
+- Added reusable Theme V2 `.btn--compact` for dense controls.
+- Applied compact styling to Hue, Sat, Brit, Name, Tag, Small, Medium, and Large buttons.
+
+## Source Palette Behavior
+- Added mock-DB seed rows through `createPaletteToolMockDbTables()`.
+- `createProjectWorkspacePaletteRepository()` still accepts:
+  - `options.sourcePaletteRows`
+  - `options.tables.palette_source_swatches`
+- Passing an empty `palette_source_swatches` table renders `No source palette`.
+- No `DEFAULT_SOURCE_PALETTES`, `DEFAULT_SOURCE_PALETTE_LABELS`, `SOURCE_PALETTES`, or `paletteList` usage is present in Palette Tool targets.
+
+## Pin All Behavior
+- `pinSourceSwatches()` pins every visible source swatch supplied by the current source/filter/sort view.
+- Already pinned source swatches are skipped by RGB key.
+- Pin All returns one batch result and does not duplicate pinned swatches.
+- The button is disabled only when there are no visible source swatches or no active project.
+
+## Compact Button Behavior
+- `.btn--compact` reduces margin, padding, font size, font weight, and line height.
+- Active sort/size buttons keep the existing `primary` selected state.
+- Active sort direction keeps the caret indicator.
+- Active Project Palette and Source Swatches place sort controls on the left and size controls on the right in the same control row.
+- The groups share the same visual baseline in the Palette Tool runtime lane.
+
+## CSS
+- Added reusable Theme V2 CSS in `assets/theme-v2/css/buttons.css`.
+- No page-local CSS, tool-local CSS, inline styles, `<style>` blocks, or inline event handlers were added.
+
+## Files Changed For Implementation
+- `assets/theme-v2/css/buttons.css`
+- `toolbox/colors/palette-workspace-repository.js`
+- `toolbox/colors/colors.js`
+- `toolbox/colors/index.html`
+- `tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+
+## Validation Summary
+- Targeted Palette Tool runtime/UI lane: PASS.
+- DB/mock-DB source swatches render visibly: PASS.
+- Empty state appears only when source palette table is empty: PASS.
+- Pin All pins visible source swatches without duplicates: PASS.
+- Compact sort/size buttons fit one row and align left/right groups on the same baseline: PASS.
+- Selected sort/size state remains visible with caret direction: PASS.
+- Changed-file/static validation: PASS.
+- Full samples smoke: not run per BUILD instruction.
diff --git a/docs_build/dev/reports/persistent_lane_manifest_report.md b/docs_build/dev/reports/persistent_lane_manifest_report.md
@@ -1,6 +1,6 @@
 # Persistent Lane Manifest Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 Manifest directory: docs_build/dev/reports/lane_manifests
 
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -12,26 +12,26 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(77%) Toolbox Index - exercised 4 runtime JS files
+(83%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
-(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
+(85%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 98/115
+(92%) toolbox/colors/colors.js - executed lines 694/694; executed functions 69/75
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
-(74%) toolbox/colors/palette-workspace-repository.js - executed lines 999/999; executed functions 81/109
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
+(85%) toolbox/colors/palette-workspace-repository.js - executed lines 1073/1073; executed functions 98/115
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
-(88%) toolbox/colors/colors.js - executed lines 687/687; executed functions 65/74
+(92%) toolbox/colors/colors.js - executed lines 694/694; executed functions 69/75
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(74%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
-(88%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(85%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
+(92%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
diff --git a/docs_build/dev/reports/retry_suppression_report.md b/docs_build/dev/reports/retry_suppression_report.md
@@ -1,6 +1,6 @@
 # Retry Suppression Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/slow_path_pruning_report.md b/docs_build/dev/reports/slow_path_pruning_report.md
@@ -1,6 +1,6 @@
 # Slow Path Pruning Report
 
-Generated: 2026-06-05T22:47:48.647Z
+Generated: 2026-06-05T23:00:27.530Z
 Status: PASS
 Source timing evidence: docs_build/dev/reports/test_cleanup_performance_report.md (2026-05-26T21:18:42.199Z)
 
diff --git a/docs_build/dev/reports/static_validation_report.md b/docs_build/dev/reports/static_validation_report.md
@@ -1,6 +1,6 @@
 # Static Validation Report
 
-Generated: 2026-06-05T22:47:48.639Z
+Generated: 2026-06-05T23:00:27.523Z
 Status: PASS
 Static only: Yes
 Dry run: No
diff --git a/docs_build/dev/reports/targeted_file_manifest_report.md b/docs_build/dev/reports/targeted_file_manifest_report.md
@@ -1,6 +1,6 @@
 # Targeted File Manifest Report
 
-Generated: 2026-06-05T22:47:48.645Z
+Generated: 2026-06-05T23:00:27.528Z
 Status: PASS
 
 ## Manifest-Generated Lane Inputs
diff --git a/docs_build/dev/reports/test_cleanup_performance_report.md b/docs_build/dev/reports/test_cleanup_performance_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Performance Report
 
-Generated: 2026-06-05T22:47:48.647Z
+Generated: 2026-06-05T23:00:27.530Z
 Status: PASS
 
 ## Cost Summary
diff --git a/docs_build/dev/reports/test_cleanup_routing_report.md b/docs_build/dev/reports/test_cleanup_routing_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Routing Report
 
-Generated: 2026-06-05T22:47:48.647Z
+Generated: 2026-06-05T23:00:27.530Z
 Status: PASS
 
 ## Representative Routing Cases
diff --git a/docs_build/dev/reports/testing_lane_execution_report.md b/docs_build/dev/reports/testing_lane_execution_report.md
@@ -1,4 +1,4 @@
-# PR_26156_170 Testing Lane Execution Report
+# PR_26156_171 Testing Lane Execution Report
 
 ## Result
 PASS
@@ -22,14 +22,25 @@ PASS
 - Changed-file/static validation: PASS.
 
 ## Playwright Coverage
-- Source palettes from DB/mock-DB rows only: PASS.
-- Empty source palette diagnostic: PASS.
-- Sort controls are left-aligned buttons with visible active state and caret direction: PASS.
-- Size controls are right-aligned buttons with visible active state: PASS.
-- Active Project Palette and Source Swatches use consistent controls: PASS.
-- Swatch-only list rendering, upper-right pin, hover glow, and native browser `title` tooltip: PASS.
+- Source Palette Browser loads mock-DB `palette_source_swatches` rows: PASS.
+- Source swatches render visibly when DB/mock-DB rows exist: PASS.
+- Empty source palette diagnostic appears only with an explicitly empty source table: PASS.
+- Pin All pins the visible filtered source swatches: PASS.
+- Pin All skips already pinned swatches without duplicates: PASS.
+- Compact Hue/Sat/Brit/Name/Tag and Small/Medium/Large buttons fit one row: PASS.
+- Left/right control groups align on the same baseline: PASS.
+- Active sort/size state and caret direction remain visible: PASS.
+- Swatch-only list rendering, upper-right pin, hover glow, and native browser `title` tooltip remain covered: PASS.
 - Harmony controls and Add Selected action remain covered: PASS.
 
+## Impacted Lane
+- Palette Tool runtime/UI lane.
+- Theme V2 static validation for reusable `.btn--compact`.
+
+## Skipped Lanes
+- Full samples smoke was skipped by BUILD instruction.
+- Broader tool lanes were skipped because the Theme V2 change is a button modifier covered in the Palette Tool consumer lane plus static validation.
+
 ## Not Run
 - Full samples smoke was not run, per BUILD instruction.
 
diff --git a/docs_build/dev/reports/validation_cache_report.md b/docs_build/dev/reports/validation_cache_report.md
@@ -1,6 +1,6 @@
 # Validation Cache Report
 
-Generated: 2026-06-05T22:47:48.646Z
+Generated: 2026-06-05T23:00:27.529Z
 Status: PASS
 
 ## Cache Summary
diff --git a/docs_build/dev/reports/zero_browser_preflight_report.md b/docs_build/dev/reports/zero_browser_preflight_report.md
@@ -1,6 +1,6 @@
 # Zero-Browser Preflight Report
 
-Generated: 2026-06-05T22:47:48.646Z
+Generated: 2026-06-05T23:00:27.529Z
 Status: PASS
 
 ## Prevented Browser Launches
diff --git a/tests/playwright/tools/PaletteToolMockRepository.spec.mjs b/tests/playwright/tools/PaletteToolMockRepository.spec.mjs
diff --git a/toolbox/colors/colors.js b/toolbox/colors/colors.js
diff --git a/toolbox/colors/index.html b/toolbox/colors/index.html
diff --git a/toolbox/colors/palette-workspace-repository.js b/toolbox/colors/palette-workspace-repository.js

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,14 @@`
`17`	`17`	`border-color: var(--orange-border-strong)`
`18`	`18`	`}`
`19`	`19`
	`20`	`+.btn--compact {`
	`21`	`+ margin: var(--space-0);`
	`22`	`+ padding: var(--space-3) var(--space-8);`
	`23`	`+ font-size: var(--font-size-xs);`
	`24`	`+ font-weight: 600;`
	`25`	`+ line-height: var(--line-height-sm)`
	`26`	`+}`
	`27`	`+`
`20`	`28`	`.btn.cyan {`
`21`	`29`	`background: var(--button-cyan-background)`
`22`	`30`	`}`