Skip to content

Commit fcd56a2

Browse files
ToolboxAidToolboxAid
committed
Use the individual commit comment generated for each PR. Do not squash PR_26152_144 through PR_26152_148 into a single commit.
1 parent e79f980 commit fcd56a2

10 files changed

Lines changed: 418 additions & 0 deletions

‎docs/dev/reports/sample_rebuild_inventory.md‎

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,101 @@
1+
# Sample Rebuild Inventory
2+
3+
PR: PR_26152_144-sample-rebuild-inventory
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Inventoried existing samples.
9+
- Identified sample JSON/schema mismatch categories.
10+
- Marked samples as pending rebuild.
11+
- Did not modify sample JSON.
12+
- Did not run sample launch validation.
13+
14+
## Inventory Sources
15+
16+
- `samples/`
17+
- `tools/schemas/game.manifest.schema.json`
18+
- `tools/schemas/tools/*.schema.json`
19+
- `docs/dev/reports/projectworkspace_migration_closeout.md`
20+
21+
## Sample Inventory
22+
23+
| Area | Count | Status | Notes |
24+
| --- | ---: | --- | --- |
25+
| Sample files under `samples/` | 1579 | INFO | Static file inventory only. |
26+
| Sample directories | 256 | INFO | Directories matching `samples/phase-*/####`. |
27+
| JSON files under `samples/` | 63 | INFO | Static JSON inventory only; no launch validation. |
28+
| Phase groups | 19 | INFO | `phase-01` through `phase-19`. |
29+
| Sample launch validation | 0 | SKIP | Explicitly out of scope for this planning lane. |
30+
| Sample JSON edits | 0 | SKIP | No sample JSON was modified. |
31+
32+
## Static JSON Categories
33+
34+
| Category | Count | Status | Rebuild Need |
35+
| --- | ---: | --- | --- |
36+
| Legacy tool wrapper JSON | 33 | PENDING | Files shaped as `tool` / `version` / `payload` must be rebuilt into approved manifest, Tool State, and ProjectWorkspace handoff boundaries. |
37+
| Standalone palette JSON | 20 | PENDING | Palette data must align with approved palette ownership and explicit project/tool context. |
38+
| Legacy tilemap documents | 6 | PENDING | `toolbox.tilemap/1` documents must be mapped into current Tile Map Editor payload boundaries. |
39+
| Workspace manifest sample | 1 | PENDING | `sample.1902.workspace-all-tools.json` references a workspace manifest schema surface that is not currently present under `tools/schemas/`. |
40+
| Payload root array | 1 | PENDING | Text to Speech V2 payload is schema-shaped but still needs explicit manifest/ProjectWorkspace handoff planning. |
41+
| Metadata/link JSON | 2 | SKIP | Metadata/index support files are not sample payload rebuild targets in this lane. |
42+
43+
## Tool Payload Categories
44+
45+
| Tool / Category | Count | Status | Notes |
46+
| --- | ---: | --- | --- |
47+
| `palette-manager-v2` standalone palette payloads | 20 | PENDING | Needs project ownership and handoff alignment. |
48+
| `tile-map-editor` payloads and documents | 13 | PENDING | Includes legacy wrapper and tilemap document forms. |
49+
| `sprite-editor` payloads | 9 | PENDING | Needs current `spriteProject` payload alignment. |
50+
| `parallax-editor` payloads | 4 | PENDING | Needs current parallax payload alignment. |
51+
| `svg-asset-studio` legacy payloads | 4 | PENDING | Needs current asset/vector ownership mapping decision. |
52+
| `tile-model-converter` legacy payloads | 3 | PENDING | Needs current tool mapping or retirement decision. |
53+
| `vector-map-editor` legacy payloads | 3 | PENDING | Needs current vector/tool mapping decision. |
54+
| `asset-browser` legacy payloads | 2 | PENDING | Needs current asset manager/browser ownership mapping decision. |
55+
| `asset-pipeline` payloads | 1 | PENDING | Needs current asset pipeline payload alignment. |
56+
| `text2speech-V2` payloads | 1 | PENDING | Payload schema exists; handoff boundary remains to be rebuilt. |
57+
| `workspace-manager-v2` project/workspace sample | 1 | PENDING | Needs sample rebuild target decision against current ProjectWorkspace terminology. |
58+
59+
## Mismatch Categories
60+
61+
- Legacy standalone payloads are not yet represented as rebuilt sample manifests with explicit ProjectWorkspace handoff inputs.
62+
- Some samples use retired or renamed tool IDs such as `svg-asset-studio`, `vector-map-editor`, `tile-model-converter`, and `asset-browser`.
63+
- Palette samples are standalone data documents rather than project-owned sample handoff records.
64+
- Tilemap samples mix wrapper JSON and `toolbox.tilemap/1` documents.
65+
- `sample.1902.workspace-all-tools.json` references `tools/schemas/workspace.manifest.schema.json`, but no matching workspace schema file is present in the current schema directory.
66+
- Rebuilt samples must avoid hidden `localStorage`, `sessionStorage`, fallback, or runtime state assumptions.
67+
- Rebuilt image references must use file/path fields such as image names or paths, never persisted `imageDataUrl`.
68+
69+
## Validation
70+
71+
Command:
72+
73+
```powershell
74+
git diff --check
75+
```
76+
77+
Result: PASS.
78+
79+
## Lanes Executed
80+
81+
- docs/report inventory only.
82+
83+
## Lanes Skipped
84+
85+
- samples - SKIP / pending rebuild; sample launch validation was not run.
86+
- runtime - no runtime behavior changed.
87+
- integration - no feature integration changed.
88+
- engine - no engine code changed.
89+
- Playwright - not impacted.
90+
91+
## Samples Decision
92+
93+
SKIP / pending rebuild. No sample JSON was modified.
94+
95+
## Playwright
96+
97+
Playwright impacted: No.
98+
99+
## Blocker Scope
100+
101+
No blockers for docs-only sample rebuild inventory. Rebuild execution remains future work.

‎docs/dev/reports/sample_rebuild_planning_closeout.md‎

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
# Sample Rebuild Planning Closeout
2+
3+
PR: PR_26152_148-sample-rebuild-planning-closeout
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Closed sample rebuild planning lane.
9+
- Confirmed rebuild execution can start next.
10+
- Confirmed unrebuild samples remain SKIP.
11+
- Made no sample JSON changes.
12+
13+
## Planning Closeout
14+
15+
| Area | Status | Notes |
16+
| --- | --- | --- |
17+
| Sample inventory | PASS | Existing sample tree and mismatch categories are documented. |
18+
| Schema target plan | PASS | Manifest, Tool State, ProjectWorkspace, payload, and asset reference boundaries are documented. |
19+
| Wave 1 scope | PASS | Exact first rebuild wave sample directories and JSON files are named. |
20+
| Validation lane | PASS | PASS/FAIL/SKIP rules are documented for rebuilt vs unrebuild samples. |
21+
| Sample JSON changes | SKIP | No sample JSON was modified. |
22+
| Sample launch validation | SKIP | Not run in this planning lane. |
23+
| Unrebuild samples | SKIP | Remain pending rebuild and must not be classified as failures. |
24+
25+
## Next Execution Lane
26+
27+
Sample rebuild execution can start next with the exact Wave 1 scope:
28+
29+
- `samples/phase-19/1902`
30+
- `samples/phase-19/1903`
31+
- `samples/phase-14/1413`
32+
- `samples/phase-14/1414`
33+
- `samples/phase-12/1208`
34+
35+
Future execution PRs should rebuild only the sample JSON they name, then validate only those rebuilt samples.
36+
37+
## Validation
38+
39+
Command:
40+
41+
```powershell
42+
git diff --check
43+
```
44+
45+
Result: PASS.
46+
47+
## Lanes Executed
48+
49+
- docs/report planning closeout only.
50+
51+
## Lanes Skipped
52+
53+
- samples - SKIP / pending rebuild; sample launch validation was not run.
54+
- runtime - no runtime behavior changed.
55+
- integration - no feature integration changed.
56+
- engine - no engine code changed.
57+
- Playwright - not impacted.
58+
59+
## Samples Decision
60+
61+
SKIP / pending rebuild. No sample JSON was modified. Rebuild execution can start next, and unrebuild samples remain SKIP.
62+
63+
## Playwright
64+
65+
Playwright impacted: No.
66+
67+
## Remaining Blockers
68+
69+
None for the sample rebuild planning lane. Execution blockers, if any, should be discovered only inside future rebuilt-sample PR scopes.

‎docs/dev/reports/sample_rebuild_validation_lane.md‎

Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
# Sample Rebuild Validation Lane
2+
3+
PR: PR_26152_147-sample-rebuild-validation-lane
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Defined sample rebuild validation lane.
9+
- Defined when sample launch validation becomes active.
10+
- Defined PASS/FAIL/SKIP rules for rebuilt vs unrebuild samples.
11+
- Did not require all samples to pass.
12+
13+
## Validation Activation Rules
14+
15+
| Case | Status Rule | Notes |
16+
| --- | --- | --- |
17+
| Rebuilt sample JSON modified in the active PR | PASS/FAIL | Validate only the rebuilt sample files and their declared handoff. |
18+
| Rebuilt sample launch added in the active PR | PASS/FAIL | Run targeted launch validation only for rebuilt samples. |
19+
| Unrebuild sample outside active PR scope | SKIP | Do not classify unrebuild samples as failures. |
20+
| Legacy sample JSON still pending rebuild | SKIP | Document as pending rebuild. |
21+
| Sample metadata/index support files | SKIP unless explicitly scoped | Do not expand validation into unrelated sample support files. |
22+
| Full sample tree validation | SKIP | Not required until a future explicit full-lane PR. |
23+
24+
## Required Future Validation Sequence
25+
26+
1. Static JSON parse for rebuilt sample files.
27+
2. Schema validation against the selected manifest/tool payload schema.
28+
3. ProjectWorkspace launch boundary validation.
29+
4. Manifest handoff boundary validation.
30+
5. Tool State ownership boundary validation.
31+
6. Targeted sample launch smoke only when explicitly scoped.
32+
33+
## PASS/FAIL/SKIP Vocabulary
34+
35+
| Status | Meaning |
36+
| --- | --- |
37+
| PASS | Rebuilt sample satisfies the exact validation lane requested by its execution PR. |
38+
| FAIL | Rebuilt sample in scope violates the selected schema, handoff, ownership, or launch rule. |
39+
| WARN | Rebuilt sample has non-blocking follow-up that does not violate the active lane. |
40+
| SKIP | Sample is not rebuilt, not scoped, pending rebuild, or belongs to a future lane. |
41+
42+
## Guardrails
43+
44+
- Do not run sample launch validation for unrebuild samples.
45+
- Do not require all samples to pass.
46+
- Do not modify sample JSON in planning PRs.
47+
- Do not rely on `localStorage`, `sessionStorage`, hidden bootstrap data, or fallback data.
48+
- Do not persist `imageDataUrl`; use file/path fields as source of truth.
49+
- Use ProjectWorkspace terminology for active handoff and lifecycle boundaries.
50+
51+
## Validation
52+
53+
Command:
54+
55+
```powershell
56+
git diff --check
57+
```
58+
59+
Result: PASS.
60+
61+
## Lanes Executed
62+
63+
- docs/report validation-lane planning only.
64+
65+
## Lanes Skipped
66+
67+
- samples - SKIP / pending rebuild; sample launch validation was not run.
68+
- runtime - no runtime behavior changed.
69+
- integration - no feature integration changed.
70+
- engine - no engine code changed.
71+
- Playwright - not impacted.
72+
73+
## Samples Decision
74+
75+
SKIP / pending rebuild. Rebuilt samples only become PASS/FAIL validation targets in future execution PRs.
76+
77+
## Playwright
78+
79+
Playwright impacted: No.
80+
81+
## Blocker Scope
82+
83+
No blockers for docs-only sample rebuild validation lane planning.

‎docs/dev/reports/sample_rebuild_wave_1_scope.md‎

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
# Sample Rebuild Wave 1 Scope
2+
3+
PR: PR_26152_146-sample-rebuild-wave-1-scope
4+
Date: 2026-06-02
5+
6+
## Scope
7+
8+
- Defined Sample Rebuild Wave 1 scope.
9+
- Identified exact samples for the first rebuild wave.
10+
- Defined expected validation for rebuilt samples only.
11+
- Did not rebuild samples.
12+
13+
## Wave 1 Sample Set
14+
15+
| Sample | Current Payload Coverage | Reason |
16+
| --- | --- | --- |
17+
| `samples/phase-19/1902` | Workspace all-tools sample | Starts with the most ProjectWorkspace-relevant sample and resolves missing workspace schema/reference direction first. |
18+
| `samples/phase-19/1903` | Text to Speech V2 payload | Small schema-shaped root array payload; good first low-risk handoff sample. |
19+
| `samples/phase-14/1413` | Asset Pipeline payload | Covers asset pipeline payload ownership without broad sample tree churn. |
20+
| `samples/phase-14/1414` | Sprite Editor plus palette payloads | Covers sprite/palette relationship and current `spriteProject` target alignment. |
21+
| `samples/phase-12/1208` | Tile Map Editor, Parallax Editor, palette, and legacy SVG asset payloads | Covers the highest-value multi-tool sample with tile/parallax/asset boundaries. |
22+
23+
## Wave 1 Exact JSON Targets
24+
25+
- `samples/phase-19/1902/sample.1902.workspace-all-tools.json`
26+
- `samples/phase-19/1903/sample.1903.text2speech-V2.json`
27+
- `samples/phase-14/1413/sample.1413.asset-pipeline.json`
28+
- `samples/phase-14/1414/sample.1414.sprite-editor.json`
29+
- `samples/phase-14/1414/sample.1414.palette.json`
30+
- `samples/phase-12/1208/sample.1208.tile-map-editor.json`
31+
- `samples/phase-12/1208/sample.1208.parallax-editor.json`
32+
- `samples/phase-12/1208/sample.1208.palette.json`
33+
- `samples/phase-12/1208/sample.1208.svg-asset-studio.json`
34+
35+
## Expected Future Validation For Rebuilt Samples Only
36+
37+
| Validation | Applies When | Result Rule |
38+
| --- | --- | --- |
39+
| Static JSON parse | After rebuild modifies a sample JSON file | PASS/FAIL for rebuilt file only. |
40+
| Schema validation | After target schema mapping is implemented or selected | PASS/FAIL for rebuilt file only. |
41+
| ProjectWorkspace launch boundary | After rebuilt sample defines explicit launch handoff | PASS/FAIL for rebuilt sample only. |
42+
| Tool State boundary | After rebuilt sample defines Tool State payload | PASS/FAIL for rebuilt sample only. |
43+
| Sample launch smoke | Future execution PR only | PASS/FAIL for rebuilt sample only; unrebuild samples remain SKIP. |
44+
45+
## Out Of Scope
46+
47+
- No sample JSON changes.
48+
- No sample launch validation.
49+
- No full sample tree validation.
50+
- No runtime implementation.
51+
- No broad sample migration.
52+
53+
## Validation
54+
55+
Command:
56+
57+
```powershell
58+
git diff --check
59+
```
60+
61+
Result: PASS.
62+
63+
## Lanes Executed
64+
65+
- docs/report Wave 1 sample scope only.
66+
67+
## Lanes Skipped
68+
69+
- samples - SKIP / pending rebuild; sample launch validation was not run.
70+
- runtime - no runtime behavior changed.
71+
- integration - no feature integration changed.
72+
- engine - no engine code changed.
73+
- Playwright - not impacted.
74+
75+
## Samples Decision
76+
77+
SKIP / pending rebuild. No sample JSON was modified. Only the exact Wave 1 sample set listed above should become active validation targets in future rebuild PRs.
78+
79+
## Playwright
80+
81+
Playwright impacted: No.
82+
83+
## Blocker Scope
84+
85+
No blockers for docs-only Wave 1 sample rebuild scoping.

0 commit comments

Comments
 (0)