PR_26172_OWNER_034-canonical-project-source-of-truth#249
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9065b65096
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Owner | ||
| - Alfa | ||
| - Bravo | ||
| - Charlie | ||
| - Golf |
There was a problem hiding this comment.
Keep the canonical team set consistent
This list is now the authoritative active-team list, but the same required Project Instructions still mark Delta as canonical: PROJECT_STATE.md still includes Delta in active_teams, and standards/CODEX_WORKFLOW_COMMANDS.md still allows Start of Day Delta and says active names include Delta. Any Delta workflow now hits contradictory governance about whether Delta is active; either include Delta here or update the other active docs in this PR.
Useful? React with 👍 / 👎.
| ## Current Version/Date | ||
|
|
||
| - Project Instructions Version: 2026-06-28.PR_26179_OWNER_010 | ||
| - Project Instructions Version: 2026-06-28.PR_26172_OWNER_034 |
There was a problem hiding this comment.
Keep the instruction version aligned
Changing this metadata to PR_26172 makes PROJECT_INSTRUCTIONS.md disagree with the required PROJECT_STATE.md, which still records project_instructions_version and latest_owner_pr as PR_26179_OWNER_010. Start-of-Day reporting loads both files and reports both versions, so wrappers/operators now see a regressed and inconsistent instruction version; keep this line at the current project-state version or update PROJECT_STATE.md consistently.
Useful? React with 👍 / 👎.
| @@ -6,9 +6,42 @@ | ||
|
|
There was a problem hiding this comment.
Regenerate the review diff as a valid patch
The stored .diff is not a valid unified diff because blank context lines were written without the required leading space, starting immediately after this hunk header; git apply --check dev/reports/codex_review.diff reports corrupt patch at line 48. Since the completion contract requires a diff artifact when changes occur, this evidence cannot be mechanically verified or applied; regenerate it from git diff without stripping line prefixes.
Useful? React with 👍 / 👎.
|
|
||
| Changed files: | ||
| M .gitignore | ||
| dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md |
There was a problem hiding this comment.
List the full branch delta in changed files
This required changed-file report now contains only PROJECT_INSTRUCTIONS.md, but the commit also adds the PR report/checklist/validation files and updates codex_review.diff plus this file. Consumers that use this artifact to verify the final branch delta will miss most of the committed changes and status evidence; regenerate the report from the actual git status/diff output or list every changed file.
Useful? React with 👍 / 👎.
|
|
||
| Codex, ChatGPT, wrappers, and team operators must use the current repository documentation under `dev/build/ProjectInstructions/` as authority for active rules. Prior chat history, remembered conversation context, generated reports, archived documents, local notes, or stale external instructions must not override repository documentation. | ||
|
|
||
| If current chat instructions conflict with repository documentation, Codex must follow the active repository documentation or HARD STOP and request OWNER direction. |
There was a problem hiding this comment.
Do not demote current task instructions
When the Owner gives task-specific instructions in the current prompt that intentionally narrow a run, such as review-only work or not generating a PR, this rule tells Codex to follow repository docs or hard-stop instead of obeying the live instruction. The stated purpose is to avoid stale history, but including current chat instructions makes valid one-off directions impossible unless the repo docs already say the same thing; limit this override to prior or stale context.
Useful? React with 👍 / 👎.
| | --- | --- | --- | | ||
| | Diff whitespace | `git diff --check` | PASS | | ||
| | Canonical structure | `npm run validate:canonical-structure` | PASS, 0 blocking violations | | ||
| | Deprecated active-team names | `rg -n "\b(Alpha|Beta|Gamma)\b" dev\build\ProjectInstructions` | PASS with intentional matches only | |
There was a problem hiding this comment.
Use a rerunnable validation path
In the repo's normal bash environment, the recorded command treats the backslashes in dev\build\ProjectInstructions as escapes and rg receives devbuildProjectInstructions, which exits with “No such file or directory” rather than running the scan this report marks as PASS. Anyone rechecking this validation on Linux/macOS will get a failure; record the portable dev/build/ProjectInstructions path or explicitly identify a Windows-only shell.
Useful? React with 👍 / 👎.
|
|
||
| The repository is the canonical source of truth for project rules. | ||
|
|
||
| Codex, ChatGPT, wrappers, and team operators must use the current repository documentation under `dev/build/ProjectInstructions/` as authority for active rules. Prior chat history, remembered conversation context, generated reports, archived documents, local notes, or stale external instructions must not override repository documentation. |
There was a problem hiding this comment.
Keep referenced docs authoritative
This sentence limits active-rule authority to docs under dev/build/ProjectInstructions/, but the same file still requires loading referenced docs outside that tree, such as dev/build/database/ for DB, DDL, DML, seed, or API persistence work. For those tasks, a wrapper following the new top-level rule can ignore the referenced database documentation because it is outside the declared authority boundary; include all referenced active docs in the canonical source scope or move the references inside it.
Useful? React with 👍 / 👎.
PR_26172_OWNER_034-canonical-project-source-of-truth
Purpose
Make repository documentation the canonical source of truth for project rules so Codex and ChatGPT do not rely on stale conversation history.
Summary
PROJECT_INSTRUCTIONS.md.Scope Boundary
PROJECT_MULTI_PC.txtfile was created or restored.Validation
git diff --check: PASSnpm run validate:canonical-structure: PASSdev/build/ProjectInstructions/: PASS with only intentional prohibition/historical non-team phrase matches.