-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26179_OWNER_011-team-stacked-pr-policy #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,10 @@ For Independent PRs and for the first PR in a new stacked workstream, no team cr | |
|
|
||
| For dependent Stacked PRs, the start branch may be the documented previous PR branch only when `dev/build/ProjectInstructions/addendums/pr_workflow.md` identifies a direct dependency and dependency order. | ||
|
|
||
| OWNER PRs may start from synchronized `main` when marked Independent and no direct dependency exists. | ||
|
|
||
| A non-Owner team PR may start from `main` only when OWNER explicitly marks the PR as `standalone/no-dependency`. Otherwise, non-Owner team PRs use Stacked PR workstreams by default and must start from the active team workstream branch or documented previous PR branch. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For a non-Owner team starting the first PR in a new stacked workstream, this file's Team Branch Creation Gate still requires the initial branch to be created only after the Useful? React with 👍 / 👎. |
||
|
|
||
| If any required check fails, or if the current branch does not match the requested PR model, stop before branch creation and restore the expected branch state or request OWNER direction. | ||
|
|
||
| ## Branch Lifecycle (Canonical) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # PR_26179_OWNER_011-team-stacked-pr-policy Branch Validation | ||
|
|
||
| ## Result | ||
|
|
||
| PASS | ||
|
|
||
| ## Checks | ||
|
|
||
| | Check | Result | Notes | | ||
| | --- | --- | --- | | ||
| | Stacked PR model identified | PASS | This PR depends on PR #255. | | ||
| | Started from documented previous PR branch | PASS | Started from `PR_26179_OWNER_011-pr-branching-model-docs`. | | ||
| | Worktree clean before branch creation | PASS | Verified before branch creation. | | ||
| | PR branch created | PASS | `PR_26179_OWNER_011-team-stacked-pr-policy`. | | ||
| | Work stayed on PR branch | PASS | No direct commit to `main`. | | ||
| | Documentation/governance scope | PASS | Only Project Instructions and reports changed. | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # PR_26179_OWNER_011-team-stacked-pr-policy Manual Validation Notes | ||
|
|
||
| ## Notes | ||
|
|
||
| - Confirmed this policy PR is stacked on PR #255 because it refines the Independent PR vs Stacked PR model introduced there. | ||
| - Confirmed the new text does not weaken dependency-order, review-order, or merge-order requirements. | ||
| - Confirmed the Codex Completion Contract still requires ZIP output for all outcomes. | ||
| - Confirmed missing ZIP output is now explicitly described as an incomplete Codex run. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # PR_26179_OWNER_011-team-stacked-pr-policy Report | ||
|
|
||
| ## Purpose | ||
|
|
||
| Update active Project Instructions so OWNER may create independent PRs from `main`, while non-Owner teams use stacked PR workstreams by default. | ||
|
|
||
| ## Branching Model | ||
|
|
||
| - Model: Stacked PR | ||
| - Previous PR dependency: `PR_26179_OWNER_011-pr-branching-model-docs` / PR #255 | ||
| - Starting branch: `PR_26179_OWNER_011-pr-branching-model-docs` | ||
| - Merge order: PR #255 first, then this PR | ||
|
|
||
| ## Governance Outcome | ||
|
|
||
| - OWNER PRs may start from synchronized `main` when independent and no direct dependency exists. | ||
| - Non-Owner team PRs use Stacked PR workstreams by default. | ||
| - Non-Owner team PRs may start from `main` only when OWNER explicitly marks the PR as `standalone/no-dependency`. | ||
| - Stacked PRs still must document dependency order, review order, and merge order. | ||
| - Codex must hard-stop when a branch/model mismatch is detected. | ||
| - Missing ZIP output is clarified as an incomplete Codex run. | ||
|
|
||
| ## Updated Documents | ||
|
|
||
| - `dev/build/ProjectInstructions/addendums/pr_workflow.md` | ||
| - `dev/build/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md` | ||
| - `dev/build/ProjectInstructions/addendums/branch_lock_governance.md` | ||
| - `dev/build/ProjectInstructions/addendums/branch_context_governance.md` | ||
| - `dev/build/ProjectInstructions/standards/CODEX_WORKFLOW_COMMANDS.md` | ||
| - `dev/build/ProjectInstructions/TEAM_START_COMMANDS.md` | ||
| - `dev/build/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md` | ||
|
|
||
| ## Runtime Impact | ||
|
|
||
| None. This PR changes documentation/governance only. | ||
|
|
||
| ## ZIP | ||
|
|
||
| - `dev/workspace/zips/PR_26179_OWNER_011-team-stacked-pr-policy_delta.zip` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # PR_26179_OWNER_011-team-stacked-pr-policy Requirement Checklist | ||
|
|
||
| | Requirement | Result | Notes | | ||
| | --- | --- | --- | | ||
| | OWNER PRs may start from main when independent | PASS | Added to PR workflow, branch lock, EOD lock, and team start docs. | | ||
| | Non-Owner team PRs stacked by default | PASS | Added to PR workflow and branch governance docs. | | ||
| | Stacked PRs must document dependency order | PASS | Preserved and reinforced from prior model. | | ||
| | Stacked PRs reviewed and merged in order | PASS | Preserved in `pr_workflow.md`. | | ||
| | Non-Owner team may start from main only when OWNER marks standalone/no-dependency | PASS | Added explicit hard-stop rules. | | ||
| | Preserve Codex Completion Contract ZIP output | PASS | Existing contract preserved. | | ||
| | Clarify missing ZIP means incomplete | PASS | Updated artifact standard language. | | ||
| | Do not modify runtime code | PASS | Documentation/governance only. | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PR_26179_OWNER_011-team-stacked-pr-policy Validation Report | ||
|
|
||
| ## Validation | ||
|
|
||
| - `git diff --check`: PASS | ||
| - `npm run validate:canonical-structure`: PASS | ||
| - Project Instructions grep for team stacked policy and ZIP completion language: PASS | ||
|
|
||
| ## Playwright | ||
|
|
||
| Not impacted. No runtime, UI, API, database, or product page files changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a stacked PR is meant to continue from an active team workstream branch that is not itself the documented previous PR branch, this new alternative is immediately contradicted by the existing hard-stop rule below that only permits
the documented previous PR branch. As written, Codex will still hard-stop for the active-workstream branch path introduced here; update the mismatch rule to accept the documented active workstream branch as well.Useful? React with 👍 / 👎.