PR_26179_OWNER_012-project-instructions-startup-validation#257
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56cdd88133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,12 @@ | |||
| # Project Instructions Version | |||
|
|
|||
| Current Project Instructions Version: 2026-06-28.PR_26179_OWNER_012 | |||
There was a problem hiding this comment.
This new version string reuses PR_26179_OWNER_012, which already identifies the existing PR_26179_OWNER_012-gitignore-env-simplification report in this repository. In the startup-validation flow, responses will print only v2026-06-28.PR_26179_OWNER_012, so operators or automation keyed on the version cannot distinguish this Project Instructions update from the earlier PR, defeating the new version-proof contract. Please use an unused PR/version identifier or include the full unique PR slug in the version.
Useful? React with 👍 / 👎.
| - Validate branching model. | ||
| - Validate ZIP and report locations. | ||
|
|
||
| Every Codex response must begin with: |
There was a problem hiding this comment.
For review or validation runs where the caller requires a strict JSON or other machine-readable payload, this unconditional prefix makes it impossible to satisfy the caller while also following Project Instructions, and the new section explicitly applies to Review and Validation outcomes. In those contexts the startup prose corrupts the response before the required payload can be parsed, so the contract needs an exception or alternate artifact-based proof for schema-constrained outputs.
Useful? React with 👍 / 👎.
|
|
||
| Legacy path check | ||
| ----------------- | ||
| tmp/ ............. PASS (not used) |
There was a problem hiding this comment.
The root /workspace/HTML-JavaScript-Gaming/AGENTS.md Packaging rule says every BUILD ZIP output path is <project folder>/tmp/<TASK_NAME>_delta.zip, but this mandatory startup block now tells BUILD tasks that tmp/ is not used. Because the block applies to BUILD outcomes, agents following it will omit the ZIP location required by the repo-level instructions unless this is reconciled or the precedence is made explicit.
Useful? React with 👍 / 👎.
| ## Current Version/Date | ||
|
|
||
| - Project Instructions Version: 2026-06-28.PR_26172_OWNER_034 | ||
| - Project Instructions Version: 2026-06-28.PR_26179_OWNER_012 |
There was a problem hiding this comment.
This bumps the human-readable Project Instructions version, but dev/build/ProjectInstructions/PROJECT_STATE.md still reports project_instructions_version: "2026-06-28.PR_26179_OWNER_010" even though the required read order always loads that state file. Any wrapper or agent that uses the machine-friendly state metadata to validate the startup version will see the repository as still on OWNER_010 and can falsely fail or skip this new startup contract, so the state metadata needs to be updated with the same version.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 913ee75307
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| diff --git a/dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md b/dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md | ||
| index 415f3675b..c5dc06241 100644 | ||
| --- a/dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md | ||
| +++ b/dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md |
There was a problem hiding this comment.
When this artifact is used as the PR delta, it cannot be applied to the actual base of ea1c0965: the commit's parent has no PROJECT_INSTRUCTIONS_VERSION.md, but the stored diff treats it as an existing file (index ..., --- a/...) instead of a new-file addition. Regenerate codex_review.diff against ea1c0965^ so APPLY/review consumers get a usable repo-structured delta for this PR.
Useful? React with 👍 / 👎.
| M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md | ||
| M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md | ||
| M dev/reports/PR_26179_OWNER_012-project-instructions-startup-validation_manual-validation-notes.md | ||
| M dev/reports/PR_26179_OWNER_012-project-instructions-startup-validation_report.md | ||
| M dev/reports/PR_26179_OWNER_012-project-instructions-startup-validation_requirement-checklist.md | ||
| M dev/reports/PR_26179_OWNER_012-project-instructions-startup-validation_validation-report.md |
There was a problem hiding this comment.
For ea1c0965^..ea1c0965, several files are added and codex_review.diff is modified, but this manifest reports the new version/report files as M and omits both the added branch-validation report and the modified diff artifact. If this file is packaged or used to audit the PR scope, consumers miss required files and cannot distinguish newly created artifacts from pre-existing ones, so regenerate it from the actual PR-base diff/status before closeout.
Useful? React with 👍 / 👎.
ToolboxAid
changed the base branch from
PR_26179_OWNER_011-team-stacked-pr-policy
to
main
1 participant
PR_26179_OWNER_012-project-instructions-startup-validation Report
Purpose
Strengthen the Project Instructions startup contract so every Codex task proves it loaded the latest Project Instructions before performing work.
Branching Model
PR_26179_OWNER_011-team-stacked-pr-policy/ PR PR_26179_OWNER_011-team-stacked-pr-policy #256PR_26179_OWNER_011-team-stacked-pr-policyGovernance Outcome
dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md.2026.06.28.001.PROJECT_INSTRUCTIONS.md.Instruction Source, proving repository instructions are used and cached memory is discarded.Runtime Impact
None. This PR changes documentation/governance only.
ZIP
dev/workspace/zips/PR_26179_OWNER_012-project-instructions-startup-validation_delta.zip