Skip to content

PR_26180_BRAVO_002-complete-messages-creator-tool#270

Merged
ToolboxAid merged 2 commits into
mainfrom
PR_26180_BRAVO_002-complete-messages-creator-tool
Jun 28, 2026
Merged

PR_26180_BRAVO_002-complete-messages-creator-tool#270
ToolboxAid merged 2 commits into
mainfrom
PR_26180_BRAVO_002-complete-messages-creator-tool

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Completes the API-backed Messages Creator Tool MVP fields for Speaker, Text, Trigger, Typewriter Speed, and TTS Profile.
  • Preserves existing Text To Speech profile, Emotion Profile, playback, guest redirect, and referenced-message delete protection behavior.
  • Fixes the Playwright repo server root used by the impacted browser validation lanes.

Validation

  • PASS: node --test dev/tests/tools/Text2SpeechShell.test.mjs dev/tests/tools/MessagesPlaybackSource.test.mjs dev/tests/dev-runtime/MessagesPublishValidation.test.mjs
  • PASS: npx playwright test --config dev/workspace/tmp/pr_26180_bravo_002.playwright.headless.config.cjs dev/tests/playwright/tools/MessagesTool.spec.mjs --project=playwright
  • PASS: npx playwright test --config dev/workspace/tmp/pr_26180_bravo_002.playwright.headless.config.cjs dev/tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright

Known Out-of-Scope Blocker

  • Full DbSeedIntegrity remains blocked outside PR_002 because dev/build/database/seed/guest/game-crew.json publishes game-crew while canonical inventory expects Game Crew under users.
  • This PR intentionally does not modify Game Crew guest seed JSON or DbSeedIntegrity expectations.

Artifacts

  • dev/reports/codex_review.diff
  • dev/reports/codex_changed_files.txt
  • dev/reports/PR_26180_BRAVO_002-complete-messages-creator-tool.md
  • dev/workspace/zips/PR_26180_BRAVO_002-complete-messages-creator-tool_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 17:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba3bcf505f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const AUTHENTICATED_MESSAGES_WRITE_RESOURCES = Object.freeze([
"categories",
"emotion-profiles",
"event-actions",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add sign-in handling before gating event actions

When an unauthenticated creator opens the Events tool and saves an action, the client still posts directly to /messages/event-actions from assets/toolbox/events/js/index.js without any session check or redirect. Adding event-actions to this new auth-gated resource list makes that save return 401, so Events regresses to a generic “not saved” failure instead of the guest-save redirect behavior added to Message Studio. Either exclude event actions from this gate or update the Events client to require/redirect before saving.

Useful? React with 👍 / 👎.

…mplete-messages-creator-tool

# Conflicts:
#	dev/reports/codex_changed_files.txt
#	dev/reports/codex_review.diff
@ToolboxAid ToolboxAid merged commit 8c332fc into main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant