PR_26180_BRAVO_002-complete-messages-creator-tool#270
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba3bcf505f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const AUTHENTICATED_MESSAGES_WRITE_RESOURCES = Object.freeze([ | ||
| "categories", | ||
| "emotion-profiles", | ||
| "event-actions", |
There was a problem hiding this comment.
Add sign-in handling before gating event actions
When an unauthenticated creator opens the Events tool and saves an action, the client still posts directly to /messages/event-actions from assets/toolbox/events/js/index.js without any session check or redirect. Adding event-actions to this new auth-gated resource list makes that save return 401, so Events regresses to a generic “not saved” failure instead of the guest-save redirect behavior added to Message Studio. Either exclude event actions from this gate or update the Events client to require/redirect before saving.
Useful? React with 👍 / 👎.
…mplete-messages-creator-tool # Conflicts: # dev/reports/codex_changed_files.txt # dev/reports/codex_review.diff
Summary
Validation
node --test dev/tests/tools/Text2SpeechShell.test.mjs dev/tests/tools/MessagesPlaybackSource.test.mjs dev/tests/dev-runtime/MessagesPublishValidation.test.mjsnpx playwright test --config dev/workspace/tmp/pr_26180_bravo_002.playwright.headless.config.cjs dev/tests/playwright/tools/MessagesTool.spec.mjs --project=playwrightnpx playwright test --config dev/workspace/tmp/pr_26180_bravo_002.playwright.headless.config.cjs dev/tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwrightKnown Out-of-Scope Blocker
DbSeedIntegrityremains blocked outside PR_002 becausedev/build/database/seed/guest/game-crew.jsonpublishesgame-crewwhile canonical inventory expects Game Crew underusers.DbSeedIntegrityexpectations.Artifacts
dev/reports/codex_review.diffdev/reports/codex_changed_files.txtdev/reports/PR_26180_BRAVO_002-complete-messages-creator-tool.mddev/workspace/zips/PR_26180_BRAVO_002-complete-messages-creator-tool_delta.zip