Skip to content

PR_26179_CHARLIE_038-sprites-grid-dimension-fix#278

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_038-sprites-grid-dimension-fix
Jun 28, 2026
Merged

PR_26179_CHARLIE_038-sprites-grid-dimension-fix#278
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_038-sprites-grid-dimension-fix

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Fix Sprite Creator center canvas grid dimensions.
  • Load the shared Sprite/Theme V2 CSS on the Sprite Creator page.
  • Replace invalid variable repeat grid tracks with explicit 16x16 and 32x32 row/column templates.
  • Add Playwright coverage for exact cell counts, exact computed row/column tracks, complete last row, and zoom-stable dimensions.

Validation

  • PASS: node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
  • PASS: git diff --check for touched files
  • PASS: runtime guard scan for inline style/script/event handlers and stale placeholder copy
  • PASS: npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list

Artifact

  • dev/workspace/zip/PR_26179_CHARLIE_038-sprites-grid-dimension-fix_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:20
@ToolboxAid ToolboxAid changed the base branch from PR_26179_CHARLIE_037-sprites-animation-export to main June 28, 2026 20:20
@ToolboxAid ToolboxAid merged commit e34a5e2 into main Jun 28, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fb2e4cf73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<meta name="description" content="Create and review pixel sprites for games with a Creator-focused workspace shell.">
<link rel="icon" href="/favicon.svg">
<link rel="stylesheet" href="assets/theme-v2/css/theme.css">
<link rel="stylesheet" href="assets/theme-v2/css/gamefoundrystudio.css">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Load sprite styles without overriding wide layout

When this page is opened on wider viewports, loading gamefoundrystudio.css after theme.css causes its broad aggregate selectors to win the cascade: assets/theme-v2/css/gamefoundrystudio.css defines .container { width: min(1180px, ...) } and .tool-workspace { grid-template-columns: 280px ... }, which override layout.css's .container--tool-wide and .tool-workspace--wide rules used by this Sprite Creator page. The result is that the intentionally wide three-column editor is capped/narrowed again even though the page still carries the wide classes; consider loading only the sprite-specific rules or ordering the aggregate stylesheet so the Theme V2 layout classes remain authoritative.

Useful? React with 👍 / 👎.


## ZIP

`dev/workspace/zip/PR_26179_CHARLIE_038-sprites-grid-dimension-fix_delta.zip`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Put the delta ZIP under tmp

For this BUILD handoff, the repo AGENTS.md Packaging section requires the delta ZIP at <project folder>/tmp/<TASK_NAME>_delta.zip, but the report records dev/workspace/zip/... instead. Automation or reviewers following the documented contract will look in tmp/ and miss the artifact for this task, so please generate/report the ZIP at tmp/PR_26179_CHARLIE_038-sprites-grid-dimension-fix_delta.zip while keeping it untracked.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant