PR_26179_CHARLIE_038-sprites-grid-dimension-fix#278
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fb2e4cf73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <meta name="description" content="Create and review pixel sprites for games with a Creator-focused workspace shell."> | ||
| <link rel="icon" href="/favicon.svg"> | ||
| <link rel="stylesheet" href="assets/theme-v2/css/theme.css"> | ||
| <link rel="stylesheet" href="assets/theme-v2/css/gamefoundrystudio.css"> |
There was a problem hiding this comment.
Load sprite styles without overriding wide layout
When this page is opened on wider viewports, loading gamefoundrystudio.css after theme.css causes its broad aggregate selectors to win the cascade: assets/theme-v2/css/gamefoundrystudio.css defines .container { width: min(1180px, ...) } and .tool-workspace { grid-template-columns: 280px ... }, which override layout.css's .container--tool-wide and .tool-workspace--wide rules used by this Sprite Creator page. The result is that the intentionally wide three-column editor is capped/narrowed again even though the page still carries the wide classes; consider loading only the sprite-specific rules or ordering the aggregate stylesheet so the Theme V2 layout classes remain authoritative.
Useful? React with 👍 / 👎.
|
|
||
| ## ZIP | ||
|
|
||
| `dev/workspace/zip/PR_26179_CHARLIE_038-sprites-grid-dimension-fix_delta.zip` |
There was a problem hiding this comment.
For this BUILD handoff, the repo AGENTS.md Packaging section requires the delta ZIP at <project folder>/tmp/<TASK_NAME>_delta.zip, but the report records dev/workspace/zip/... instead. Automation or reviewers following the documented contract will look in tmp/ and miss the artifact for this task, so please generate/report the ZIP at tmp/PR_26179_CHARLIE_038-sprites-grid-dimension-fix_delta.zip while keeping it untracked.
Useful? React with 👍 / 👎.
Summary
Validation
Artifact