Fix vulnerability issues in dataset download#203
Merged
Conversation
gganapavarapu
changed the title
Signed-off-by: Giridhar Ganapavarapu <giridhar.ganapavarapu@ibm.com>
Replace retired ubuntu-20.04 with ubuntu-latest, upgrade actions/checkout from v3 to v4, and actions/setup-python from v4 to v5 to resolve runner timeouts and Node.js 20 deprecation warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dennis Wei <dwei@us.ibm.com> Signed-off-by: Giridhar Ganapavarapu <giridhar.ganapavarapu@ibm.com>
cvxpy 1.4+ no longer bundles the ECOS solver, causing the rbm tests to fail with "The solver ECOS is not installed." Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dennis Wei <dwei@us.ibm.com> Signed-off-by: Giridhar Ganapavarapu <giridhar.ganapavarapu@ibm.com>
On arm64 macOS runners, Homebrew installs to /opt/homebrew which is not in the default compiler search path. Export CFLAGS/LDFLAGS so pygraphviz can find the graphviz headers and libraries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dennis Wei <dwei@us.ibm.com> Signed-off-by: Giridhar Ganapavarapu <giridhar.ganapavarapu@ibm.com>
rule_induction, tsice, tssaliency, and tslime pin pandas<2.0.0 but left numpy unconstrained. pip installs numpy 2.x which is binary- incompatible with pandas 1.x, causing "numpy.dtype size changed" errors at import time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dennis Wei <dwei@us.ibm.com> Signed-off-by: Giridhar Ganapavarapu <giridhar.ganapavarapu@ibm.com>
Collaborator
|
Thanks @gganapavarapu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes high-severity dataset download issues in
ClimateDatasetandFordDatasetby hardening remote archive fetching and extraction.Changes made
ClimateDataset._validate_url()andFordDataset._validate_url()ClimateDataset._download_and_extract()andFordDataset._download_and_extract()Security impact
Addresses:
Validation
python3 -m compileall