Skip to content

Wire GPU NMF engine into CLI#2

Merged
OlivierBakker merged 2 commits into
TrynkaLab:mainfrom
JerryIshihara:features/nmf-gpu-wiring
Jun 29, 2026
Merged

Wire GPU NMF engine into CLI#2
OlivierBakker merged 2 commits into
TrynkaLab:mainfrom
JerryIshihara:features/nmf-gpu-wiring

Conversation

@JerryIshihara

Copy link
Copy Markdown

Summary

This PR wires the existing standalone GPU NMF kernel into the cNMF CLI factorization path.

Changes

  • Adds optional NMF engine CLI args for factorize
  • Keeps the default path as CPU/sklearn behavior
  • Enables GPU NMF only when --engine gpu is passed
  • Passes GPU runtime options into the cNMF _nmf adapter
  • Raises errors when GPU options are used with unsupported commands or without --engine gpu

@OlivierBakker OlivierBakker merged commit 6336388 into TrynkaLab:main Jun 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants