Skip to content

Adds test coverage for the GPU NMF CLI wiring#3

Merged
OlivierBakker merged 1 commit into
TrynkaLab:mainfrom
JerryIshihara:tests/nmf-gpu-wiring
Jul 1, 2026
Merged

Adds test coverage for the GPU NMF CLI wiring#3
OlivierBakker merged 1 commit into
TrynkaLab:mainfrom
JerryIshihara:tests/nmf-gpu-wiring

Conversation

@JerryIshihara

Copy link
Copy Markdown

Summary

Adds test coverage for the GPU NMF CLI wiring added to cNMF.

Changes

  • Tests GPU CLI argument defaults, validation, and normalization
  • Tests that GPU options require --engine gpu
  • Tests that GPU engine options are scoped to supported commands
  • Tests CPU engine behavior remains unchanged
  • Tests GPU engine patching of the cNMF _nmf path
  • Tests cNMF factorize passes replicate seeds, component count, run params, and GPU kwargs into the GPU adapter
  • Verifies factorize still writes expected spectra outputs

@OlivierBakker OlivierBakker merged commit f1fd201 into TrynkaLab:main Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants