Skip to content

Add cNMF GPU consensus test coverage#5

Merged
OlivierBakker merged 1 commit into
TrynkaLab:mainfrom
JerryIshihara:tests/nmf-gpu-consensus-tests
Jul 2, 2026
Merged

Add cNMF GPU consensus test coverage#5
OlivierBakker merged 1 commit into
TrynkaLab:mainfrom
JerryIshihara:tests/nmf-gpu-consensus-tests

Conversation

@JerryIshihara

Copy link
Copy Markdown

Summary

Adds test coverage for the GPU consensus/refit path in cNMF.

Changes

  • Validates GPU CLI options are accepted for both factorize and consensus
  • Keeps GPU options rejected for non-engine commands like prepare, combine,
    and k_selection_plot
  • Tests fixed-H GPU kernel behavior for consensus refit:
    • update_H=False preserves supplied spectra H
    • usages W are updated with fixed-H MU
    • invalid fixed H inputs raise clear errors
    • fixed-H compile path uses _mu_step_fixed_h
    • fixed-H fit loop respects early stop and max-iter bounds
  • Adds cNMF integration tests for:
    • refit_usage() GPU wiring
    • refit_spectra() transposed GPU wiring
    • tiny CPU-backed GPU consensus smoke outputs
    • default CPU consensus path not leaking engine/gpu kwargs

@JerryIshihara JerryIshihara force-pushed the tests/nmf-gpu-consensus-tests branch from af4cf51 to 458b852 Compare July 1, 2026 14:55
@OlivierBakker OlivierBakker merged commit 7b984fb into TrynkaLab:main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants