Treat timer triggers as external resume triggers#136
Closed
radu-mocanu wants to merge 2 commits into
Closed
Conversation
8ae4715 to
20e99b2
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the resumable runtime’s post-suspension auto-resume behavior so timer-based resume triggers are treated like external (Orchestrator-driven) resume triggers, preventing the runtime from polling and potentially self-resuming before the job is actually suspended in Orchestrator.
Changes:
- Updates
_get_fired_triggers()documentation to include Timer triggers in the “external trigger” category. - Excludes
UiPathResumeTriggerType.TIMERfrom the set of triggers eligible for immediate polling/auto-resume right after suspension.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
150
to
+169
| @@ -161,7 +162,11 @@ async def _get_fired_triggers(self) -> dict[str, Any] | None: | |||
| t | |||
| for t in triggers | |||
| if t.trigger_type | |||
| not in (UiPathResumeTriggerType.API, UiPathResumeTriggerType.INBOX) | |||
| not in ( | |||
| UiPathResumeTriggerType.API, | |||
| UiPathResumeTriggerType.INBOX, | |||
| UiPathResumeTriggerType.TIMER, | |||
| ) | |||
fc7d0db to
4947104
Compare
|
Collaborator
Author
|
Closing in favor of the split runtime PR stack starting at #137. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Timer resume triggers are completed by Orchestrator after the job suspends. The resumable runtime should persist them and let Orchestrator handle the wake-up instead of polling them immediately in the same process, which can self-resume before the job ever reaches Suspended.
Development Package