Skip to content

fix!: adapt to updated python sdk#49

Closed
yehonatanz wants to merge 2 commits into
Universal-Commerce-Protocol:mainfrom
yehonatanz:chore-adapt-to-updated-python-sdk
Closed

fix!: adapt to updated python sdk#49
yehonatanz wants to merge 2 commits into
Universal-Commerce-Protocol:mainfrom
yehonatanz:chore-adapt-to-updated-python-sdk

Conversation

@yehonatanz

Copy link
Copy Markdown

Description

Adapt SDK usage to changes from Universal-Commerce-Protocol/python-sdk#48

  • minor fix in extracting shopping services

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Is this a Breaking Change or Removal?

Yes

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

Python SDK has been updated in a non backwards compatible way, this is a breaking change that adapts this repo to the SDK's breakin change.


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@damaz91

damaz91 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for flagging. We are fixing this directly in the Python SDK as part of Universal-Commerce-Protocol/python-sdk#51 - once that's done, we'll merge #50 to bring back conformance to "green" state!

@damaz91 damaz91 closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Signal that the PR is ready for human triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants