refactor: use ucp-sdk from pip by default in python samples#130
Closed
damaz91 wants to merge 4 commits into
Closed
refactor: use ucp-sdk from pip by default in python samples#130damaz91 wants to merge 4 commits into
damaz91 wants to merge 4 commits into
Conversation
Path-filter push/pull_request triggers to rest/python/** and the workflow file itself, matching the path-filtered shape of the Node.js workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes booting the Python server.
The Python server consumes ucp-sdk as an editable path dependency, so the purpose of this job is to catch server-vs-SDK drift as it happens. Pinning the SDK to a fixed SHA turns the check green by testing a frozen combination and hides exactly the drift it exists to surface. Track main instead; a red run is the signal to adapt the server (as samples#127 did for the SDK type-alias change). Verified: samples main + python-sdk main boot and pass the integration tests + happy-path client.
Remove local path dependencies from pyproject.toml files and update GHA workflow to install local SDK override manually to retain drift detection. TAG=agy CONV=bfc6d8af-a5ae-4fbd-ad20-b3d689857d05
damaz91
force-pushed
the
feature/use-pip-sdk
branch
from
6030a29 to
9185bc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Python samples to use the published
ucp-sdkfrom PyPI by default, rather than expecting a local checkout ofpython-sdkat a relative path.It also updates the GHA workflow to manually install the local SDK checkout to retain drift detection, and updates READMEs to document optional local SDK development.
Category (Required)
Checklist
!for breaking changes).