Skip to content

Reject unknown OpenAPI tool arguments#1388

Merged
RhysSullivan merged 1 commit into
mainfrom
fix-1382-unknown-args
Jul 10, 2026
Merged

Reject unknown OpenAPI tool arguments#1388
RhysSullivan merged 1 commit into
mainfrom
fix-1382-unknown-args

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Generated tool schemas declare additionalProperties: false, but nothing enforced it: an unknown top-level argument was silently dropped from the outgoing request, so a mis-named payload key (requestBody instead of body) produced a confusing upstream 400 instead of a local error.

buildRequest now compares the caller's keys against what the operation actually consumes (declared parameters, path placeholders, body/input, bodyBase64 and contentType where applicable, server for multi-server operations) and fails locally naming the unknown keys and listing the accepted ones. Both the direct invoke path and the approval-gated validation route go through the same check.

Fixes #1382

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 39abea3 Commit Preview URL

Branch Preview URL
Jul 10 2026, 08:05 AM

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 39abea3 Jul 10 2026, 08:06 AM

@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1388

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1388

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1388

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1388

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1388

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1388

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1388

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1388

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1388

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1388

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1388

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1388

executor

npm i https://pkg.pr.new/executor@1388

commit: 39abea3

@RhysSullivan RhysSullivan force-pushed the fix-1382-unknown-args branch from 56f5441 to 39abea3 Compare July 10, 2026 08:03
@RhysSullivan RhysSullivan marked this pull request as ready for review July 10, 2026 09:32
@RhysSullivan RhysSullivan merged commit 0e33c5e into main Jul 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openapi: additionalProperties:false is declared but never enforced

1 participant