E2E: selfhost-docker coverage fixes for shared-workspace scenarios#1396
Merged
Conversation
api-tools' fresh-identity count and org-slug-routing's unknown-slug 404 both special-cased target.name === 'selfhost', but selfhost-docker is the same single-tenant app; nothing had run these scenarios against the docker target before, so the guards never covered it.
The picker notice assertion pinned 'You have 1 personal connection...', but the selfhost workspace is shared: another scenario's personal connection legitimately raises the count (oauth-client-handoff's browser flow creates one). Match the explanation, not the number, per the e2e/AGENTS.md rule against global-count assertions.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | faffc29 | Commit Preview URL Branch Preview URL |
Jul 10 2026, 09:14 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | faffc29 | Jul 10 2026, 09:15 AM |
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the release gate (#1392) that were committed to its branch after it merged: api-tools and org-slug-routing special-cased target.name === "selfhost" but selfhost-docker is the same single-tenant app, and toolkits-ui asserted a global personal-connection count that another scenario legitimately changes. All three fail the new docker e2e release gate without this.