Skip to content

Resolve all favicons through integrations.sh/logo#1400

Merged
RhysSullivan merged 3 commits into
mainfrom
favicon-via-integrations-sh
Jul 10, 2026
Merged

Resolve all favicons through integrations.sh/logo#1400
RhysSullivan merged 3 commits into
mainfrom
favicon-via-integrations-sh

Conversation

@RhysSullivan

@RhysSullivan RhysSullivan commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Favicon resolution now goes through integrations.sh/logo only.

  • Clients no longer talk to Google's favicon service directly. The proxy already handles the Google fallback (and serves a letter placeholder for unknown domains) server-side, so the client-side fallback URL was a redundant second path to the same upstream.
  • The two remaining direct preset icon URLs (Emulate MCP, Chrome DevTools) moved onto the proxy.
  • Fixes a reported wrong-logo case: preset icon matching fuzzy-matched integration names against preset names, so "ClickHouse Cloud" matched the Cloudflare preset through the shared "cloud" fragment and rendered Cloudflare's logo. The fuzzy layer (token splitting, noise-word stripping, alias table) is removed entirely; presets now match only on exact identity signals (defaultSlug, URL equality, Google discovery service). A missed match falls through to the domain-derived integrations.sh favicon, which cannot be the wrong brand. This mirrors the integrations.sh catalog itself, where every icon is already integrations.sh/logo/{domain}.

Verified in the local app: preset library icons render, an integration added from a URL resolves its icon through the proxy, and the only external favicon requests are https://integrations.sh/logo/* (zero google.com/s2 requests).

favicon resolution via integrations.sh

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 556af51 Commit Preview URL

Branch Preview URL
Jul 10 2026, 07:38 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 10, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 556af51 Jul 10 2026, 07:40 PM

@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1400

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1400

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1400

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1400

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1400

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1400

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1400

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1400

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1400

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1400

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1400

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1400

executor

npm i https://pkg.pr.new/executor@1400

commit: 556af51

@RhysSullivan RhysSullivan marked this pull request as ready for review July 10, 2026 19:52
@RhysSullivan RhysSullivan merged commit 8bc037d into main Jul 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant