Fix domain surface consistency across landing page and registry#54
Open
rksharma-owg wants to merge 1 commit into
Open
Fix domain surface consistency across landing page and registry#54rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/disc/{domain}.json, and surface sitemap generationRoot cause
The landing page and registry summary paths were using normalized catalog/index data, while prerendered domain pages and baseline discovery JSON were deriving visible surface types from a narrower baseline that could miss discovered-domain-only formats like CLI. That let a domain such as Notion show
CLIin the registry inputs but not on the landing-page/domain representation.Shared logic introduced
src/lib/domain-surface-types.tsnormalizes surface type vocabulary to the project's existingmcp,openapi,graphql,cliordering and deduplicates themsrc/lib/domain-discovery.tsbuilds a consistent domain discovery document by combining discovered-domain surfaces, curated interfaces, and baseline catalog surfacessrc/lib/curated.ts,src/lib/discovered-catalog.ts, andsrc/lib/discovered-domains.tsprovide reusable loaders/mappers so domain-level surface joins happen in one place rather than ad hoc in page componentsPages/components changed
src/lib/catalog.tssrc/pages/[domain].astrosrc/pages/disc/[domain].json.tssrc/pages/sitemap-surfaces.xml.tsRegression tests added
Commands run
bun install✅bun run normalize✅cd cli && bun run build✅bun test✅ (72 pass, 0 fail)bun run build✅bun run validate:batchcatalogMissingLocator,catalogDuplicateSurface)Before / after for Notion
Before:
CLIAfter:
CLIfor Notionnotion.comdomain output includesMCP · REST · CLI/disc/notion.com.jsonincludes theNotion CLIsurface/api/domains.jsonfornotion.comincludescliinformatsFixes #41