Skip to content

add minimum motes for sungecko#74

Open
rileyscool wants to merge 3 commits into
V5-Client:mainfrom
rileyscool:main
Open

add minimum motes for sungecko#74
rileyscool wants to merge 3 commits into
V5-Client:mainfrom
rileyscool:main

Conversation

@rileyscool

Copy link
Copy Markdown

vibe coded motes check before sun gecko fight

it tweaks out if motes is less than 5k, so stop macro if motes arent enough to enter
@lemunzzz62

Copy link
Copy Markdown

vibecode was not needed for this but nonetheless a fair addition

@rileyscool

Copy link
Copy Markdown
Author

didnt know how to read scoreboard and couldnt be fucked reading docs for anything

@EpsilonPhoenix

Copy link
Copy Markdown
Member

Do what your AI did:

Read the existing codebase.

Scoreboard.getLines();

@EpsilonPhoenix EpsilonPhoenix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a few issues

}
var motes = this.getMotesFromScoreboard();
if (motes !== null && motes < MINIMUM_MOTES) {
this.toggle(false);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say it in chat! Don't toggle off without stating the reason.

Comment thread modules/other/SunGeckoMacro.js Outdated
}

getMotesFromScoreboard() {
try {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a try catch

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not
(ai)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not (ai)

tell the ai to fix it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants