feat(governance): add voting quorum rules and minimum_quorum config - #394
Open
peaceshallom37-rgb wants to merge 1 commit into
Open
feat(governance): add voting quorum rules and minimum_quorum config#394peaceshallom37-rgb wants to merge 1 commit into
peaceshallom37-rgb wants to merge 1 commit into
Conversation
Adds quorum enforcement to the governance contract: - New MinimumQuorum storage (admin-configurable, 0-100%) - New TotalAddressedVoters tracks unique voter count via HasEverVoted - New QuorumNotMet error (VertexChainLabs#13) - execute_proposal now checks participation >= minimum_quorum - set_minimum_quorum/get_minimum_quorum admin-only entry points - New quorum tests: met, not-met, mixed votes, 0%, >100% reject, 100% - Removes dead events.rs (inlined into lib.rs) Closes VertexChainLabs#135
Author
|
@snowrugar-beep — requesting review for this PR. CI is pending first-time contributor approval. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #135 — Governance: voting quorum rules + snapshot tests
Changes
MinimumQuorumstorage (admin-configurable, 0–100%)TotalAddressedVoterscounter withHasEverVoteddeduplicationQuorumNotMeterror variant (security: replace regex-based HTML sanitizer with DOMPurify #13)execute_proposal: participation/totalUniqueVoters ≥ minimum_quorumset_minimum_quorum()/get_minimum_quorum()admin-only contract entry pointsevents.rs(inlined intolib.rs)initializesignatureAcceptance Criteria
QuorumNotMet (#13)panicsFWC26
USDC distribution via Stellar.