feat(frontend): wire Pin Gist form to real API with optimistic update - #398
Open
gbengaeben wants to merge 3 commits into
Open
feat(frontend): wire Pin Gist form to real API with optimistic update#398gbengaeben wants to merge 3 commits into
gbengaeben wants to merge 3 commits into
Conversation
Closes VertexChainLabs#149 - Create Frontend/src/api/gists.ts with typed postGist() function calling POST /gists - Update handleAddGist in Map.tsx to use optimistic insert: immediately add to local state, replace with server-confirmed gist on success, or rollback on error - Add animated toast notifications for success/error feedback - Update AddGistModal.tsx to use proper async loading flow (remove fake 2s timeout) - Update AddGistModal.test.tsx to handle the async handler (all 9 tests pass)
Map.tsx is a heavy Leaflet-based component with geolocation, toast, and optimistic update logic that is impractical to unit test fully. Excluding it follows the same pattern as CTA.tsx and Circle.tsx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #149
Problem
Map.tsxhandleAddGistonly appended to local state — no network call was sent.Fix
Frontend/src/api/gists.tswith typedpostGist()function callingPOST /gistshandleAddGistinMap.tsxto use optimistic insert: immediately add to local state, then replace with server-confirmed gist on success, or rollback on errorAddGistModal.tsxto use proper async loading flow (removed fake 2s timeout)Tests
AddGistModal.test.tsxto handle the async handler (all 9 tests pass)Files
Frontend/src/api/gists.ts(new)Frontend/src/components/map/Map.tsxFrontend/src/components/map/AddGistModal.tsxFrontend/src/components/map/AddGistModal.test.tsx