Conversation
|
amvertex
approved these changes
Jun 30, 2026
| "test:clean": "rm -fr ./dist-test && mkdir ./dist-test", | ||
| "pretest:build": "yarn test:clean", | ||
| "test:build": "rollup --config ./rollup.testing.js", | ||
| "test:build": "yarn workspace @vertexvis/web-workers build && yarn build && rollup --config ./rollup.testing.js", |
Contributor
There was a problem hiding this comment.
Just checking - this is something we want to merge and not only for testing, correct?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's funky. Because rollup-web-workers references web-workers, you build that first, then build all then run test. Might be able to trim this down or find a more efficient way, but this does the trick for now
| @@ -1 +1 @@ | |||
| v14.17.4 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Getting some versions of dev tools upgraded for compatibility of upcoming changes in web-sdk and web-tools.
Test Plan
expect local unit tests integration suites, and CI steps to succeed. Beyond that, will test new releases in web-sdk soon
Release Notes
Rollup, Lerna, Typescript, Jest, EsLint, all get major version upgrades.
Possible Regressions
Aiming for none, but with so many libraries changing definitely a possibility. Will be testing canary releases before cutting a new release.
Dependencies
connected to this work Vertexvis/vertex-web-tools#106
as well as Vertexvis/vertex-web-sdk#801