Build the versioned image on release so [skip ci] can't skip it#10
Merged
Conversation
Version tags (v3.3.x) land on the task-battery "Add task battery results …
[skip ci]" commit on main, so a plain tag push skips the Docker build and the
{{major}}.{{minor}} image (:3.3, the tag prod's Rancher Cattle service pulls)
never rebuilds — releases since v3.3.1 never reached prod.
Add `release: [published]` and `workflow_dispatch` triggers, which are not
subject to a tagged commit's [skip ci]. Release process becomes: tag, then
publish a GitHub Release (or run the workflow manually on the tag) to force the
:3.3 rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why releases weren't reaching prod
Prod (Rancher Cattle) pulls
virtualflybrain/vfbchat:3.3— the{{major}}.{{minor}}image, which only rebuilds on av3.3.xtag push. But every version tag lands on the task-battery bot's commit "Add task battery results … [skip ci]" (main's head after a merge). GitHub honours[skip ci]on the tagged commit and skips the Docker build, so:3.3never rebuilt after v3.3.1. Confirmed: thev3.3.3tag has 0 Docker Image CI runs. Everything since v3.3.1 (auto-run injector, semantics, typing) is on Docker Hub under other tags but not in:3.3.Fix
Add
release: [published]andworkflow_dispatchtriggers. Neither is subject to a tagged commit's[skip ci], so the versioned image always rebuilds. Release process becomes: create the tag, then publish a GitHub Release for it (or run Docker Image CI manually on the tag) →:3.3/:3.3.xrebuild.To get current code live now (no wait on this PR)
The
[skip ci]skip is only on the tagged commit, so tag a non-[skip ci]commit. The PR #9 merge commitbc8d584("Merge pull request #9") has the current code and no[skip ci]:That fires the existing
tags: 'v*'build → rebuilds:3.3. Then in Rancher upgrade the Cattle service and force-pull (same-tag:3.3won't re-pull otherwise).I can create that tag for you on your OK.