Safety: hard-cap every run_query response at 10k rows (VFBQUERY_RESULT_ROW_CAP)#66
Merged
Conversation
added 2 commits
July 10, 2026 17:25
…e (v2-dev deploy)
…T_ROW_CAP) Broad terms make many queries huge or unbounded — e.g. AllAlignedImages ~528k, and ListAllAvailableImages / SubclassesOf / connectivity on high-level classes (FBbt_00005106 'neuron') return -1/unresolved counts, i.e. potentially millions. Returning any of those in one response is what caused the 430MB serialise-on-the-event-loop + websocket broken-pipe blowup. Bound every run_query (and _dispatch_to_pool) result to RESULT_ROW_CAP rows (env VFBQUERY_RESULT_ROW_CAP, default 10000; 0 disables), keep the true total in count, and flag capped so the UI can show 'first N — refine'. No-op for results that are already small, for AllAlignedImages pages (already <=10k, native paged), and for non-row payloads like term_info. This makes the service safe for production against any large/unbounded query, independent of the client.
Robbie1977
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.