with_solr_cache: honour offset when slicing cached full results (fixe…#71
Merged
Conversation
…s owlery-family paging) Paged owlery-family queries (NeuronsPartHere, PartsOf, SubclassesOf, neurons_synaptic/pre/post, etc.) served every page by slicing the cached full result with [:limit], ignoring offset, so page 2+ returned the same rows as page 1. The client's duplicate-first-row guard then halted the stream at ">10000", leaving big generic terms (e.g. nervous system: 18262 neurons / 20870 parts) looking unpopulated. Two fixes in the @with_solr_cache wrapper: - Force offset=0 on every limit=-1 (full) kwargs copy so the cached full set is always complete, regardless of which page first triggered the compute. - Slice returns with [offset:offset+limit] (and DataFrame .iloc[...]) instead of [:limit]/.head(limit), preserving the true total count. AllAlignedImages is unaffected (it pages via its own id-index, not this slice path). The term_info preview slice is unchanged (offset not applicable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s owlery-family paging)
Paged owlery-family queries (NeuronsPartHere, PartsOf, SubclassesOf, neurons_synaptic/pre/post, etc.) served every page by slicing the cached full result with [:limit], ignoring offset, so page 2+ returned the same rows as page 1. The client's duplicate-first-row guard then halted the stream at ">10000", leaving big generic terms (e.g. nervous system: 18262 neurons / 20870 parts) looking unpopulated.
Two fixes in the @with_solr_cache wrapper:
AllAlignedImages is unaffected (it pages via its own id-index, not this slice path). The term_info preview slice is unchanged (offset not applicable).