Fix SimilarMorphologyTo 500 + gate, upgrade all thumbnail URLs to https#72
Merged
Robbie1977 merged 1 commit intoJul 13, 2026
Merged
Conversation
Robbie1977
commented
Jul 13, 2026
Robbie1977
commented
Contributor
- with_solr_cache: never pass offset to wrapped funcs that don't declare it (get_similar_neurons lacked offset -> TypeError on cache miss; the wrapper already slices for offset itself). Fixes SimilarMorphologyTo 500 on every neuron that has NBLAST data.
- SimilarMorphologyTo gate: require the NBLAST facet (was Individual+Neuron), so the query is no longer offered to neurons with no similarity data and returning 0 rows (e.g. MaleCNS/BANC).
- Upgrade every Cypher-built thumbnail URL http-> https (17 sites incl. neuron-neuron connectivity) so thumbnails aren't mixed-content blocked.
- Bump version 1.22.24 -> 1.22.25.
- with_solr_cache: never pass offset to wrapped funcs that don't declare it (get_similar_neurons lacked offset -> TypeError on cache miss; the wrapper already slices for offset itself). Fixes SimilarMorphologyTo 500 on every neuron that has NBLAST data. - SimilarMorphologyTo gate: require the NBLAST facet (was Individual+Neuron), so the query is no longer offered to neurons with no similarity data and returning 0 rows (e.g. MaleCNS/BANC). - Upgrade every Cypher-built thumbnail URL http-> https (17 sites incl. neuron-neuron connectivity) so thumbnails aren't mixed-content blocked. - Bump version 1.22.24 -> 1.22.25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.