feat: add rustdoc/NatSpec-style comments to TreasuryContract public API (#191) - #304
Open
Jay989810 wants to merge 1 commit into
Conversation
Add rustdoc/NatSpec-style comments to TreasuryContract public entrypoints, structs, enums, and error types. - Document parameters, return values, and error conditions for all public functions - Keep doc comments aligned with docs/contract-interaction-guide.md - Update test setup and add unit tests for unpause, threshold, token allowlist, deposit, withdraw, and authorization checks - Fix Cargo.lock derive_arbitrary dependency lock Closes WHEELBACK#191
|
@Jay989810 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive rustdoc/NatSpec-style comments to all public entrypoints, structs, enums, and error types in the
TreasuryContract(COMEBACKHERE-contracts/contracts/treasury/src/lib.rs).Documentation comments include
# Arguments,# Returns, and# Errorssections for each function and maintain alignment withdocs/contract-interaction-guide.mdwithout duplicating essay-length prose.Closes #191
Changes Made
///doc comments for all 16 public entrypoints inTreasuryContract.SettlementStatus,Settlement,TreasuryError,DataKey, andTreasuryContract.Cargo.lock(derive_arbitrarymatched tov1.3.2).unpause,get_threshold,update_threshold,add_token_to_allowlist,remove_token_from_allowlist,deposit,withdraw, and authorization failure cases..gitignore.Verification & Test Output
1.
cargo docBuildCommand: