fix(commands): correct CODELLENS -> CODELENS typo in strict import env var - closes #39#79
Merged
Merged
Conversation
Add CODELLENS_STRICT_COMMANDS for CI/dev fail-fast when a command module fails to import, plus a meta-test ensuring every commands/*.py registers at least one CLI command. Also register the missing self-analyze command. Fixes #39
…v var syf2211's PR #69 had the env var spelled CODELLENS_STRICT_COMMANDS (double L) in all 4 files. Issue #39 specifies CODELENS_STRICT_COMMANDS (single L). Anyone reading the issue and setting the env var with the correct spelling would get no effect - strict mode silently wouldn't activate. This fixup branch is based on syf2211's work (credited) with only the typo corrected. All other changes (strict mode fail-fast, self_analyze registration fix, meta-test, CI integration) are unchanged. Closes #39 Supersedes #69
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixup of PR #69 by syf2211. The original PR had the env var spelled
CODELLENS_STRICT_COMMANDS(double L) in all 4 files. Issue #39 specifiesCODELENS_STRICT_COMMANDS(single L). This PR corrects the typo and supersedes #69.What changed
Only the typo fix (
CODELLENStoCODELENS) in 4 files:.gitlab-ci.ymlscripts/commands/__init__.pytests/conftest.pytests/test_command_registry.pyPlus
uv.lockadded to.gitignore(artifact from local testing, should not be committed).All other changes from syf2211's PR #69 are unchanged:
CODELENS_STRICT_COMMANDS=1env var re-raises import failures (matches issue [BUG-09] Command auto-import silently drops broken modules — registry missing commands with no CI signal #39 spec)self_analyze.pyregistration fix (found a real bug - module loaded but never calledregister_command)tests/conftest.pyenables strict mode for all pytest runstest_every_command_module_registersmeta-testtest_strict_command_imports_fail_fast_on_broken_modulesubprocess test.gitlab-ci.ymlsets env var globally for CICredit
All implementation credit to @syf2211 (PR #69). This fixup branch only corrects the env var typo that was blocking merge.
Verification
PYTHONPATH=scripts CODELENS_STRICT_COMMANDS=1 python3 -m pytest tests/test_command_registry.py -v- 2 passedCODELLENSremaining in any file (verified via grep)Related