Add italic to STET occurrence reference counting - #323
Merged
Conversation
When a reference count is shown the PO wants it not just bold but also italicized.
PurpleGuitar
approved these changes
Jul 10, 2026
Comment on lines
351
to
360
| source_ref_display = verse.source_reference | ||
| if verse.occurrence_total > 1: | ||
| source_ref_display += ( | ||
| f" ({verse.occurrence_index}/{verse.occurrence_total})" | ||
| ) | ||
| target_ref_display = verse.target_reference | ||
| if verse.occurrence_total > 1: | ||
| target_ref_display += ( | ||
| f" ({verse.occurrence_index}/{verse.occurrence_total})" | ||
| ) |
Contributor
There was a problem hiding this comment.
I think lines 351-360 are now dead code -- I don't see any references to source_ref_display or target_ref_display elsewhere in this block. Recommend removing them if they're not used anymore.
PurpleGuitar
merged commit Jul 10, 2026
31d6523
into
WycliffeAssociates:doc-dev.walink.org
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reference count is shown the PO wants it not just bold but also italicized.