Filter out parenthesized see phrases - #324
Merged
linearcombination merged 4 commits intoJul 20, 2026
Merged
Conversation
|
|
||
|
|
||
| SEE_PARENTHETICAL_RE = re.compile( | ||
| r"\((?P<prefix_text>[^():]+:)\s*.*?\)", |
Contributor
There was a problem hiding this comment.
I think this regex needs a "[Ss]ee:" in it, or at least a "rc://", or else it's going to match anything parenthetical, like a verse reference, e.g.: (Galatians 5:15)
Contributor
Author
There was a problem hiding this comment.
Update addresses regex overreach
| Remove any parenthetical string beginning with 'See:'. | ||
| Example: '(See: something)' -> '' | ||
| """ | ||
| return see_parenthetical_re.sub("", source) |
Contributor
There was a problem hiding this comment.
I recommend adding some unit tests to demonstrate that this function is behaving as intended. I think it should remove e.g.
- (See: [[rc://...]])
- (See: Altar)
but should not remove e.g.:
- "devour one another (Galatians 5:15)."
- "precious in his sight (Isaiah 43:4)."
- "keep provisions (see 2 Chronicles 8:3)."
Of course, PO gets final say.
Contributor
Author
There was a problem hiding this comment.
Thanks for the test data
Per reviewer comments
linearcombination
merged commit Jul 20, 2026
4b880b3
into
WycliffeAssociates:doc-dev.walink.org
8 checks passed
github-project-automation
Bot
moved this from In progress
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By request of PO