Book name lookup prefs - #325
Merged
PurpleGuitar merged 3 commits intoJul 21, 2026
Merged
Conversation
Choose USFM metadata lookup order and whether to normalize per language and resource type combo. E.g., a majority of languages provide their book name in the \h USFM element, but fr f10 does so in \toc2 and for fr f10 no normalization of the looked up name is preferred whereas other languages often need this step. This commit makes it possible to easily customize per language by using a lookup table for book name lookup and a lookup table for normalization. By request of PO.
PurpleGuitar
approved these changes
Jul 21, 2026
PurpleGuitar
merged commit Jul 21, 2026
6742a70
into
WycliffeAssociates:doc-dev.walink.org
7 of 8 checks passed
github-project-automation
Bot
moved this from In progress
to Done
in DOC Project Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to specify exceptional lookup locations for localized book names. Book names come from several different potential resource locations, the default order and locations work for the most number of languages. However, for some language resource type combinations, e.g., fr f10, a different location than the default is desired because that is where the translators decided to put the localized book names that are preferred by the PO.
This PR introduces a design which allows book name lookup location for other language and resource type combinations to be specified in the future should they arise. It also provides the ability to specify if the languages and resource type combination should be skipped for localized book name normalization, e.g., again fr f10 needs this specialized exception from the default treatment. Handling fr 10 requested by PO, general design extended to handle future situattions.