Skip to content

Updated workflows to run on dev branch as well#19

Open
abidiqbalxgrid wants to merge 2 commits into
masterfrom
workflows
Open

Updated workflows to run on dev branch as well#19
abidiqbalxgrid wants to merge 2 commits into
masterfrom
workflows

Conversation

@abidiqbalxgrid

@abidiqbalxgrid abidiqbalxgrid commented May 22, 2023

Copy link
Copy Markdown
Contributor

XkOps

Issue

No issue

Description

Updated workflows to run on dev branch as well. The code first needs to be merged on the dev branch with all tests being passed. From dev, the deployment action will run which will deploy the code to EKS. After this test passes, we should merge the code in master

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes (if applicable)
  • Every function, interface, class has a comment describing what it does and input/output parameters

@github-actions

github-actions Bot commented May 22, 2023

Copy link
Copy Markdown

🤖 OpenAI


Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

Files not summarized due to errors (1)

Failed to summarize

  • .github/workflows/deploy_xkops.yml (nothing obtained from openai)

In the recent run, only the files that changed from the base of the PR and between d0b259a410bc77f6326d6b3113a271e82a7c77a8 and 7790645260d26b575956a3e5cbdee613408d4196 commits were reviewed.

Files not reviewed due to errors in the recent run (1)

Failed to review in the last run

  • .github/workflows/deploy_xkops.yml (no response)

@alikhanxgrid alikhanxgrid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update description as to why we need to run actions on dev branch.

@abidiqbalxgrid

Copy link
Copy Markdown
Contributor Author

Update description as to why we need to run actions on dev branch.

Updated the Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants