Assorted patches

[SteelBlueZK]

LuaUI/Widgets/gui_reclaiminfo.lua

• Initilized 2 variables instead of 1 for clarity

effects/roach.lua

• Table defined 2 properties "groundflash", got rid of the redundant one. The redundant one was getting overwritten by the latter one.

lups/lups.lua

• global scope variable pulled back to local scope

LuaUI/Widgets/unit_smart_nanos.lua

• uhhh.... Errr... My linter informed me there was a reference to a global variable, which was probably meant to reference a local variable defined below it, but then I noticed many other things that are messy with this file.... This isn't even the default caretaker controller, and maybe it should be deleted. The logic is actually all over the place, Histidine added it to the repo "so someone else can figure it out" and noone seems to have done so.

[sprunk]

Changes in the 3 smaller files look good, some nits around smart nanos though.

[sprunk]

The project-wide convention is spFoo = Spring.Foo, but the existing lines are just Foo = Spring.Foo so now there's inconsistent style. If we're linting the file perhaps bring the others up to the spFoo standard.

[SteelBlueZK]

What do you say I remove changes to unit_smart_nanos and just push the 3 tiny changes?

my linter pointed to this line and said "global variable" and indeed "bestUnit" is global in this scope. It gets defined in local scopes down the function in 2 separate if statements.

[sprunk]

If you'd like to do more with smart nanos then a standalone PR for the 3 tiny changes to get them out of the way sounds ok.

But could also remove the sp from spGetFeaturesInCylinder to be consistent with what exists (rather than plow through the entire file to add sp to everything else) and I think that would also be immediately mergeable.