feat: add query_price helper and protocol fee boundary tests (#572) - #641
Merged
Chucks1093 merged 5 commits intoJul 30, 2026
Merged
Conversation
Contributor
|
Fix ci |
Contributor
|
I see what you have done here, the price check tool and fee edge case tests make it easy to verify the math holds at boundary values. Good work. |
Storage access is only valid inside a contract execution context; calling compute_bonding_curve_price bare in test code panics with "this function is not accessible outside of a contract".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #572
Summary
Adds a read-only \query_price(env: Env, creator: Address, supply: u64)\ helper function to \CreatorKeysContract\ along with comprehensive unit tests for \query_price\ and protocol fee calculation at boundary supply values.
Changes
Testing