test(creator-keys): add coverage for creator fee recipient update val… - #696
Merged
Chucks1093 merged 1 commit intoJul 30, 2026
Conversation
|
@funds0033-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds focused unit tests for the update_creator_fee_recipient functionality to verify successful updates, authorization checks, and zero-address validation.
What was added
Added creator-keys/tests/update_creator_fee_recipient.rs.
Added test coverage for:
Valid fee recipient updates are persisted correctly.
Zero-address recipients are rejected with ContractError::ZeroAddress.
Unauthorized callers cannot update the fee recipient and no state changes occur.
A second valid update replaces the previous recipient.
The previous recipient is no longer stored after an update.
Notes
The issue description references an invalid_recipient error, but the contract currently returns ContractError::ZeroAddress. The tests were written against the contract's actual behavior.
This PR only adds test coverage and does not modify contract logic.
Validation
Local cargo test could not be executed because the local environment is missing the MSVC link.exe toolchain.
The tests are intended to be validated by the project's GitHub CI.
Closes #681