test: add integration test for creator search no-results state - #713
Open
Damilorlar wants to merge 2 commits into
Open
test: add integration test for creator search no-results state#713Damilorlar wants to merge 2 commits into
Damilorlar wants to merge 2 commits into
Conversation
When a search query returns zero creators, the response now includes the searchTerm field so the frontend can display a no-results message that references the term. This is distinct from the unfiltered empty state (which omits searchTerm). - Add optional searchTerm to PublicCreatorListEnvelope type - Pass validatedQuery.search through serializeCreatorListResponse - Add integration test covering search no-results state - Fix pre-existing implicit any TS errors in httpGetTrendingCreators
Contributor
|
fix ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##closed #675
Summary
Add an integration test to verify that the creators list displays a dedicated no-results state when a search query returns zero matches. The test ensures users receive clear feedback that their search did not match any creators and that this state is distinct from the generic empty state shown when no search filter is applied.
What was done
zzznomatch.zzznomatchinto the search input and waited for the mocked response.Validation