argus: add ARGUS.md, wire it into the review prompt, raise max-turns to 70#412
Open
ohalushchak-exadel wants to merge 1 commit into
Open
argus: add ARGUS.md, wire it into the review prompt, raise max-turns to 70#412ohalushchak-exadel wants to merge 1 commit into
ohalushchak-exadel wants to merge 1 commit into
Conversation
…to 70 Adds a repo-root ARGUS.md that layers repo-specific priors on top of the base prompt at .github/ai-review/expert-adcp-reviewer.md. Content is scoped to invariants the base prompt does not already encode: - fcap seller_agent_url read/write symmetry (PR #406 landed canonicalization on the reader side; a new fcap.Field construction site that skips canonicalizeSellerAgentURL silently fails cap enforcement open). - The public router endpoint surface (/registry/snapshot, /tmp/context, /tmp/identity) and the TMP_* env-var contract in cmd/router/main.go. - The one novel check on top of the schema-regen MUST-FIX: the version comment at adcp/types_gen.go line 2 must match adcp/schemas/VERSION. - The closed-set error-outcome label discipline on identity-agent and context-agent metrics (targeting/identityagent/metrics.go, targeting/contextagent/metrics.go), which the base prompt does not spell out. - An explicit sync clause: every rule is a claim about how the repo behaves, so a diff that invalidates a rule must update ARGUS.md in the same PR. Applies equally to human contributors and coding agents. Sections that would have duplicated the base prompt or AGENTS.md (general TMP-signing MUST-FIX, protocol-managed skills read-only rule, pinhole overview) are deliberately omitted so ARGUS.md carries only non-duplicative signal. Workflow changes: - "Build Argus review prompt" step now cats ARGUS.md into the prompt under a "# Repo-specific context (from ARGUS.md)" header when the file exists. Absent file is a no-op. - Self-modification gate regex extended to include ^ARGUS\.md$, so edits to this file pause Argus on the containing PR the same way edits to the workflow or the base prompt do — a review agent must not approve changes to its own priors. - --max-turns raised from 60 to 70 to give the reviewer more room on the multi-hunk cross-file audits the current MUST-FIX list drives. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🛑 Argus paused on this PR. This PR modifies Argus's own configuration ( Automated by the Argus self-modification gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a repo-root
ARGUS.mdthat layers repo-specific priors on top of the base prompt at.github/ai-review/expert-adcp-reviewer.md. Deliberately scoped to invariants the base prompt does not already encode:canonicalizeSellerAgentURLintargeting/identityagent/service.go). A newfcap.Field{...}construction that skips the helper fragments cap buckets by URL spelling and silently fails cap enforcement open./registry/snapshot,/tmp/context,/tmp/identityand theTMP_*env-var prefix incmd/router/main.go. The base prompt's MUST-FIX Add CI: build, test, lint, benchmark #6 covers the conventional-commit marker; ARGUS.md names the concrete surface it applies to.adcp/types_gen.gomust matchadcp/schemas/VERSION. A drift means the regen ran against a stale bundle."timeout" | "canceled" | "error") on identity-agent and context-agent metrics, pertargeting/identityagent/metrics.goandtargeting/contextagent/metrics.go. Grafana-relevant.Sections that would have duplicated the base prompt or
AGENTS.md(general TMP-signing MUST-FIX, protocol-managed-skills read-only rule, pinhole overview, generic high-risk-paths list) are deliberately omitted. Draft caught by a Fable-5 audit pass that flagged five duplicative sections and two BLOCKING trivial-path globs — see the commit for the trim rationale.Workflow changes
Build Argus review promptstep now readsARGUS.mdif present and injects it into the prompt under a# Repo-specific context (from ARGUS.md)header before the pre-computed inputs. Missing file → no-op, existing behavior preserved.^ARGUS\.md$. Argus pauses on this PR (and any future PR that editsARGUS.md), which is intentional — a review agent must not approve changes to its own priors. CODEOWNERS gates the merge.--max-turnsraised from 60 to 70 to give the reviewer more room on the multi-hunk cross-file audits the current MUST-FIX list drives.Test plan
🤖 Generated with Claude Code