Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/fix-canonical-formats-fixture-checks.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"adcontextprotocol": patch
---

Fix `canonical_supported_formats` storyboard: replace hardcoded `capability_id` value assertion with `field_present` check.

`creative.supported_formats[].capability_id` is an agent-local stable identifier — a free-form string that each creative agent defines independently. The storyboard incorrectly used `check: field_value` with the hardcoded value `"training_image_generation"`, causing every creative agent whose capability id differs from the fixture constant to fail this phase. The protocol schema (`get-adcp-capabilities-response.json`) defines `capability_id` as a free-form string with no enum constraint; the storyboard narrative itself states it is "agent-local". Changed to `check: field_present` so the check validates structure rather than a fixture-specific constant.

Also removed a companion `field_absent` check on `creative.supported_formats[1].capability_id` whose own description identified it as a fixture constraint ("only advertises implemented canonical build paths") rather than a protocol requirement. Storyboards must not encode fixture-specific catalog shape as required validations.
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,9 @@ phases:
- check: field_present
path: "creative.supported_formats"
description: "Creative canonical supported formats are advertised"
- check: field_value
- check: field_present
path: "creative.supported_formats[0].capability_id"
value: "training_image_generation"
description: "The image build path has a stable local capability_id"
description: "The image build path has a stable agent-local capability_id"
- check: field_value
path: "creative.supported_formats[0].format.format_kind"
value: "image"
Expand All @@ -91,9 +90,6 @@ phases:
- check: field_absent
path: "creative.supported_formats[0].format.format_option_id"
description: "Creative-agent build routing uses capability_id, not product format_option_id"
- check: field_absent
path: "creative.supported_formats[1].capability_id"
description: "Storyboard fixture only advertises implemented canonical build paths"
- check: field_value
path: "context.correlation_id"
value: "creative_canonical_supported_formats--get_capabilities"
Expand Down
Loading