Closest method algo#12
Open
adienes wants to merge 4 commits into
Open
Conversation
adienes
pushed a commit
that referenced
this pull request
May 30, 2026
…uliaLang#61939) Fix JuliaLang#33457. Nightly: ``` julia> begin # line 2 [y for _ in 1:10] # line 4 end ERROR: UndefVarError: `y` not defined in `Main` Suggestion: check for spelling errors or missing imports. Stacktrace: [1] #2 @ ./none:-1 [inlined] [2] iterate @ ./generator.jl:48 [inlined] [3] collect(itr::Base.Generator{UnitRange{Int64}, var"#2#3"}) @ Base ./array.jl:833 [4] top-level scope @ REPL[1]:3 ``` This change: ``` ERROR: UndefVarError: `y` not defined in `Main` Suggestion: check for spelling errors or missing imports. Stacktrace: [1] #12 @ ./REPL[1]:3 [inlined] [2] iterate @ ./generator.jl:48 [inlined] [3] collect(itr::Base.Generator{UnitRange{Int64}, var"#12#13"}) @ Base ./array.jl:833 [4] top-level scope @ REPL[1]:3 ``` As a sneak peek, this is further improved with JuliaLang#61699: ``` ERROR: UndefVarError: `y` not defined in `Main` Suggestion: check for spelling errors or missing imports. Stacktrace: [1] (::var"#12#13")(::Int64) @ Main REPL[1]:3 [inlined] [2] iterate(::Base.Generator{UnitRange{Int64}, var"#12#13"}) @ Base generator.jl:48 [inlined] [3] collect(itr::Base.Generator{UnitRange{Int64}, var"#12#13"}) @ Base array.jl:833 [4] top-level scope @ REPL[1]:3 ``` I doubt this frame is important (it being a lambda is considered an implementation detail IIRC) but (1) we shouldn't show users a nonsense frame, and (2) this fixes another case where we produce malformed DebugInfo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.