Feature/dotenv thematisation#2306
Open
vgreb wants to merge 2 commits into
Open
Conversation
vgreb
force-pushed
the
feature/dotenv-thematisation
branch
from
6a754f7 to
76b618a
Compare
vgreb
force-pushed
the
feature/dotenv-thematisation
branch
from
76b618a to
09d13ad
Compare
vgreb
force-pushed
the
feature/dotenv-thematisation
branch
from
09d13ad to
4da5cbc
Compare
Mopolo
reviewed
Jun 28, 2026
Comment on lines
+26
to
+30
| public function __invoke(Request $request): Response | ||
| { | ||
| $id = $request->query->get('id'); | ||
|
|
||
| $event = $this->eventActionHelper->getEventById($id); |
Contributor
There was a problem hiding this comment.
Il y a un système tout fait pour récupérer l'event en cours de sélection : https://github.com/afup/web/blob/master/doc/backoffice/event-selector.md
| /** | ||
| * @return CollectionInterface<EventTheme> | ||
| */ | ||
| public function getByEventOrderedByPriority(int $eventId): CollectionInterface |
Contributor
There was a problem hiding this comment.
Suggested change
| public function getByEventOrderedByPriority(int $eventId): CollectionInterface | |
| public function getByThemesOrderedByPriority(int $eventId): CollectionInterface |
Comment on lines
+333
to
+334
| // @phpstan-ignore-next-line (generics variance) | ||
| $metadata->setRepository(self::class); |
Contributor
There was a problem hiding this comment.
Tu peux ignorer une erreur explicitement plutôt que toute la ligne :
Suggested change
| // @phpstan-ignore-next-line (generics variance) | |
| $metadata->setRepository(self::class); | |
| $metadata->setRepository(self::class); // @phpstan-ignore argument.type |
| $builder->add($idForumField) | ||
| ->add('name', TextType::class, [ | ||
| 'label' => 'Nom du thème', | ||
| 'constraints' => [new Assert\NotBlank(['message' => 'Titre du forum manquant'])], |
Contributor
There was a problem hiding this comment.
Utiliser un array c'est déprécié :
Suggested change
| 'constraints' => [new Assert\NotBlank(['message' => 'Titre du forum manquant'])], | |
| 'constraints' => [new Assert\NotBlank(message: 'Titre du forum manquant')], |
| ->add('description', TextareaType::class, [ | ||
| 'label' => 'Description', | ||
| 'help' => 'Le thème de description apparait sur la page de programme', | ||
| 'constraints' => [new Assert\NotBlank(), new Assert\Length(['max' => 600])], |
Contributor
There was a problem hiding this comment.
Pareil ici :
Suggested change
| 'constraints' => [new Assert\NotBlank(), new Assert\Length(['max' => 600])], | |
| 'constraints' => [new Assert\NotBlank(), new Assert\Length(max: 600)], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reprise de #1897