atelet: drop cosmetic gVisor-isms (generic hostname + tracer name)#334
Open
Davanum Srinivas (dims) wants to merge 1 commit into
Open
atelet: drop cosmetic gVisor-isms (generic hostname + tracer name)#334Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
Two vestigial gVisor labels in atelet's actor prep that mislead a non-gVisor backend: the generic OCI spec hard-set Hostname "runsc" (the gVisor binary name) and the untar tracer was scoped "ateom-gvisor" although it runs in atelet. Use a runtime-neutral Hostname "actor" and tracer "atelet". Cosmetic; no behavior change. (Atelet gVisor-centrism findings agent-substrate#3 + agent-substrate#8.)
Davanum Srinivas (dims)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two vestigial gVisor labels in atelet's actor prep that mislead a non-gVisor backend: the generic OCI spec hard-set
Hostname: "runsc"(the gVisor binary name), and the untar tracer was scoped"ateom-gvisor"though it runs in atelet. Switch to a runtime-neutralHostname: "actor"and tracer"atelet". Cosmetic; no behavior change.