fix(helm): remove unused grpc port 21212 and point NOTES.txt to MCP bridge - #596
Open
ajitsahu wants to merge 1 commit into
Open
fix(helm): remove unused grpc port 21212 and point NOTES.txt to MCP bridge#596ajitsahu wants to merge 1 commit into
ajitsahu wants to merge 1 commit into
Conversation
inFocus7
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
Looks good! Some minor nits then can aprove:
- There's a README.md.gotmpl file that brings up the grpc endpoint (line 20?) which no longer exists
- I think you need to run
make verifyto regenerate Helm docs with changes - The label check is failing, not sure why though 😅 (not sure if it's due to missing code block ``` string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the unused gRPC port (
21212) from the Helm chart and updatesNOTES.txtto point users to the active built-in MCP server (31313).NOTES.txtcauseddial tcp4 127.0.0.1:21212: connection refusedbecause the server binaryonly runs the HTTP API server (
8080/12121) and the MCP Bridge (31313).charts/agentregistry/templates/NOTES.txt: Updated port-forward output to point to.Values.service.ports.mcp(31313).charts/agentregistry/values.yaml: Removed unusedgrpc: 21212keys fromports,targetPorts, andnodePorts.charts/agentregistry/templates/service.yaml&deployment.yaml: Removed deadgrpcport entries.charts/agentregistry/tests/service_test.yaml: Updated Helm unit tests.Change Type
/kind fix
/kind install
Changelog