Skip to content

fix(helm): remove unused grpc port 21212 and point NOTES.txt to MCP bridge - #596

Open
ajitsahu wants to merge 1 commit into
agentregistry-dev:mainfrom
ajitsahu:fix/helm-remove-unused-grpc-port
Open

fix(helm): remove unused grpc port 21212 and point NOTES.txt to MCP bridge#596
ajitsahu wants to merge 1 commit into
agentregistry-dev:mainfrom
ajitsahu:fix/helm-remove-unused-grpc-port

Conversation

@ajitsahu

Copy link
Copy Markdown

Description

This PR cleans up the unused gRPC port (21212) from the Helm chart and updates NOTES.txt to point users to the active built-in MCP server (31313).

  • Motivation: Following the post-install instructions in NOTES.txt caused dial tcp4 127.0.0.1:21212: connection refused because the server binary
    only runs the HTTP API server (8080 / 12121) and the MCP Bridge (31313).
  • What changed:
    • charts/agentregistry/templates/NOTES.txt: Updated port-forward output to point to .Values.service.ports.mcp (31313).
    • charts/agentregistry/values.yaml: Removed unused grpc: 21212 keys from ports, targetPorts, and nodePorts.
    • charts/agentregistry/templates/service.yaml & deployment.yaml: Removed dead grpc port entries.
    • charts/agentregistry/tests/service_test.yaml: Updated Helm unit tests.
  • Related issues: Fixes [Helm Chart / Docs] Port 21212 connection refused after following Helm NOTES.txt instructions #595

Change Type

/kind fix
/kind install

Changelog

fix(helm): remove unused grpc port 21212 and point NOTES.txt to MCP bridge

@inFocus7 inFocus7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor nits then can aprove:

  1. There's a README.md.gotmpl file that brings up the grpc endpoint (line 20?) which no longer exists
  2. I think you need to run make verify to regenerate Helm docs with changes
  3. The label check is failing, not sure why though 😅 (not sure if it's due to missing code block ``` string)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Helm Chart / Docs] Port 21212 connection refused after following Helm NOTES.txt instructions

2 participants