feat(mcp): support workspace-scoped stdio cwd#2153
Conversation
|
u010143241 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR adds workspace-scoped cwd (working directory) support to MCP stdio transport as part of #2140. The change spans three layers: Core (McpClientBuilder adds a stdioTransport overload with Path workingDirectory), Harness (McpServerConfig adds a cwd JSON field; McpServerRegistrar.resolveStdioWorkingDirectory() enforces path safety — rejecting absolute paths and ../ escapes), and tests. The design is sound, security checks are in place, and cwd omission preserves host-cwd inheritance behavior. No blocking issues found.
(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)
|
Please sign the CLA at: https://cla-assistant.io/agentscope-ai/agentscope-java?pullRequest=2153 Code Review (pending CLA)Summary: Adds workspace-relative cwd support to Core stdio MCP transport and Harness MCP server config. Findings:
Verdict: Clean implementation. Ready to merge once CLA is signed. Automated review by github-manager |
Part of #2140.
Summary
Verification