fix(harness): acknowledge background task termination#2180
Open
guslegend0510 wants to merge 3 commits into
Open
fix(harness): acknowledge background task termination#2180guslegend0510 wants to merge 3 commits into
guslegend0510 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2162.
Background task cancellation previously updated the persisted task state to
CANCELLEDwithout providing authoritative acknowledgement that the underlyinglocal or remote execution had actually stopped.
This change introduces a typed cancellation contract that separates cancellation
request state from execution termination state.
Changes
TaskCancellationwith typed:awaitTermination(Duration)API.TaskRepository.cancelTask(...)API.
CompletableFuturecancellation.stop acknowledgement.
underlying execution.
after the remote protocol reports a terminal state.
signal.
task_canceloutput to distinguish request status from stop status.Behavior
TaskStatus.CANCELLEDcontinues to represent the durable repository state andcancellation intent.
It no longer implies that the child execution has stopped. Callers that need to
perform workspace cleanup or parent shutdown can wait for the termination signal
with their own timeout.
Java does not provide a safe forced thread-stop mechanism. A local supplier that
ignores interruption therefore returns
TIMED_OUTto bounded waiters until thesupplier actually exits.
Tests
Added coverage for:
Validation completed successfully:
Branch: fix/2162-task-cancellation-ack
Commit: 5764d98