Improved PriorityQueue#1196
Merged
Merged
Conversation
Contributor
Author
heapq compares the (priority, item) tuples element-wise, so two items with the same priority get compared directly - a TypeError for non-comparable items (dicts, objects without __lt__). Insert a monotonic counter as a tie-breaker: (priority, counter, item), giving deterministic FIFO ordering on ties and never comparing items. Add a test; update two ForwardPlan tests whose air_cargo/ shopping plans (equally optimal) changed with the new deterministic tie-break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explaining 861853b:
If the first element of two tuples are equal, then python tries to compare the 2nd elements, which will throw a TypeError if the 2nd elements can't be compared.
This change prevents that Error from happening in that special case.