Fix client getting stuck on unexpected server EOF#503
Open
oxy-star wants to merge 1 commit into
Open
Conversation
oxy-star
force-pushed
the
fix-infinite-loop-on-server-close
branch
from
July 9, 2026 05:46
b371777 to
f28a176
Compare
oxy-star
force-pushed
the
fix-infinite-loop-on-server-close
branch
from
July 9, 2026 05:49
f28a176 to
70ffb44
Compare
Vizonex
approved these changes
Jul 10, 2026
Vizonex
left a comment
Vizonex
left a comment
Member
There was a problem hiding this comment.
I would've added a comment about the client closing unexpectedly but this change makes logical sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix client getting stuck when server closes connection unexpectedly
Are there changes in behavior for the user?
An exception will be raised in such case instead of getting stuck forever trying to read data
Related issue number
Fixes #502
Checklist