Opt/saving files#198
Open
ipmach wants to merge 6 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| @staticmethod | ||
| @overload | ||
| def binary_file(out_: BaseSchema | bytes | None, out_path: str) -> bytes | None: | ||
| ... |
| @staticmethod | ||
| @overload | ||
| def binary_file(out_: list[BaseSchema] | list[bytes], out_path: str) -> list[bytes]: | ||
| ... |
| @overload | ||
| @staticmethod | ||
| def json(out_: BaseSchema | None, out_path: str) -> BaseSchema | None: | ||
| ... |
| @overload | ||
| @staticmethod | ||
| def json(out_: list[BaseSchema], out_path: str) -> list[BaseSchema]: | ||
| ... |
| @staticmethod | ||
| @overload | ||
| def yaml(out_: BaseSchema | None, out_path: str) -> BaseSchema | None: | ||
| ... |
| @staticmethod | ||
| @overload | ||
| def yaml(out_: list[BaseSchema], out_path: str) -> list[BaseSchema] | None: | ||
| ... |
viktorbeck98
approved these changes
Jul 6, 2026
| return func(*args, **kwargs) | ||
| else: | ||
| aux = func(*args, **kwargs) | ||
| return aux[0] if aux is not None else None |
Collaborator
There was a problem hiding this comment.
Isn't that a bit fragile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimization of To class. Before saving parsed logs or alerts could slow because the class was loading and saving to memory multiple times. Now it allows to only do it once or a smaller amount of times.
Checklist