fix: complete updates after resource removal#173
Merged
alongubkin merged 1 commit intoJul 21, 2026
Conversation
Greptile SummaryThis PR makes update completion depend on the desired stack. The main changes are:
Confidence Score: 5/5The normal resource-removal flow looks mergeable, but empty-target update semantics should be clarified.
crates/alien-deployment/src/updating.rs
|
| Filename | Overview |
|---|---|
| crates/alien-deployment/src/updating.rs | Adds target-aware status aggregation, with an empty-target edge case that can turn a fully deleted stack into Running. |
| crates/alien-deployment/tests/test_platform.rs | Adds coverage for release promotion after a removed resource reaches Deleted while preserving its tombstone. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
crates/alien-deployment/src/updating.rs:34-36
**Empty Target Becomes Running**
When an update has an empty target stack and its last resource reaches `Deleted`, the filter removes every status and this branch reports `Running`. The previous aggregation reported an all-deleted state as `Deleted`, so a whole-stack removal submitted through the update path can promote an empty deployment as running instead of preserving deletion semantics.
Reviews (1): Last reviewed commit: "fix: complete updates after resource rem..." | Re-trigger Greptile
Comment on lines
+34
to
+36
| if statuses.is_empty() { | ||
| return Ok(StackStatus::Running); | ||
| } |
There was a problem hiding this comment.
When an update has an empty target stack and its last resource reaches Deleted, the filter removes every status and this branch reports Running. The previous aggregation reported an all-deleted state as Deleted, so a whole-stack removal submitted through the update path can promote an empty deployment as running instead of preserving deletion semantics.
Prompt To Fix With AI
This is a comment left during a code review.
Path: crates/alien-deployment/src/updating.rs
Line: 34-36
Comment:
**Empty Target Becomes Running**
When an update has an empty target stack and its last resource reaches `Deleted`, the filter removes every status and this branch reports `Running`. The previous aggregation reported an all-deleted state as `Deleted`, so a whole-stack removal submitted through the update path can promote an empty deployment as running instead of preserving deletion semantics.
How can I resolve this? If you propose a fix, please make it concise.
alongubkin
deleted the
alon/alien-318-complete-updates-after-resource-removal
branch
July 21, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo nextest run -p alien-deployment --test test_platform update_completes_after_removed_resource_is_deleted